This repository was archived by the owner on Mar 3, 2026. It is now read-only.
docs: add callout for crc32c checksum and md5 hash options - #1830
Merged
ddelgrosso1 merged 4 commits intoApr 1, 2022
Conversation
product-auto-label
Bot
added
the
api: storage
ddelgrosso1
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
ddelgrosso1
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
ddelgrosso1
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
frankyn
approved these changes
Mar 29, 2022
| * completely, however this is **not recommended**. | ||
| * completely, however this is **not recommended**. If using CRC32c | ||
| * the checksum can be set in `metadata.crc32c`. For MD5 the hash can | ||
| * be set in `metadata.md5Hash`. Providing `metadata.crc32c` or |
Contributor
There was a problem hiding this comment.
What if we made this whole thing less wordy by saying:
In addition to specifying validation type, providing `metadata.crc32c` or `metadata.md5Hash` will cause the server to perform validation in addition to client validation.
shaffeeullah
approved these changes
Mar 29, 2022
shaffeeullah
left a comment
shaffeeullah
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Let's look into #1829 further before merging.
shaffeeullah
added
do not merge
ddelgrosso1
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
ddelgrosso1
added
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: