refactor: fix gocritic lint issues (#3113)

Author: alexandear

.golangci.yml

@@ -3,6 +3,15 @@ run:
   timeout: 5m
 
 linters-settings:
+  gocritic:
+    enabled-checks:
+      - emptyStringTest
+      - equalFold
+      - httpNoBody
+      - nilValReturn
+      - paramTypeCombine
+      - preferFprint
+      - yodaStyleExpr
   errcheck:
     exclude-functions:
       - (io.Writer).Write
@@ -69,6 +78,10 @@ issues:
       linters:
         - dupl
         - errcheck
+    # It's autogenerated code.
+    - path: codegen/testserver/.*/resolver\.go
+      linters:
+        - gocritic
     # Disable revive.use-any for backwards compatibility
     - path: graphql/map.go
       text: "use-any: since GO 1.18 'interface{}' can be replaced by 'any'"

_examples/chat/resolvers.go

@@ -62,7 +62,7 @@ type Chatroom struct {
 
 type mutationResolver struct{ *resolver }
 
-func (r *mutationResolver) Post(ctx context.Context, text string, username string, roomName string) (*Message, error) {
+func (r *mutationResolver) Post(ctx context.Context, text, username, roomName string) (*Message, error) {
 	room := r.getRoom(roomName)
 
 	message := &Message{

_examples/scalars/model/model.go

@@ -25,7 +25,7 @@ func (b Banned) MarshalGQL(w io.Writer) {
 func (b *Banned) UnmarshalGQL(v any) error {
 	switch v := v.(type) {
 	case string:
-		*b = strings.ToLower(v) == "true"
+		*b = Banned(strings.EqualFold(v, "true"))
 		return nil
 	case bool:
 		*b = Banned(v)

client/client.go

@@ -111,7 +111,7 @@ var boundaryRegex = regexp.MustCompile(`multipart/form-data; ?boundary=.*`)
 func (p *Client) newRequest(query string, options ...Option) (*http.Request, error) {
 	bd := &Request{
 		Query: query,
-		HTTP:  httptest.NewRequest(http.MethodPost, "/", nil),
+		HTTP:  httptest.NewRequest(http.MethodPost, "/", http.NoBody),
 	}
 	bd.HTTP.Header.Set("Content-Type", "application/json")
 
@@ -128,7 +128,7 @@ func (p *Client) newRequest(query string, options ...Option) (*http.Request, err
 	switch {
 	case boundaryRegex.MatchString(contentType):
 		break
-	case "application/json" == contentType:
+	case contentType == "application/json":
 		requestBody, err := json.Marshal(bd)
 		if err != nil {
 			return nil, fmt.Errorf("encode: %w", err)
@@ -146,7 +146,7 @@ func (p *Client) SetCustomDecodeConfig(dc *mapstructure.DecoderConfig) {
 	p.dc = dc
 }
 
-func unpack(data any, into any, customDc *mapstructure.DecoderConfig) error {
+func unpack(data, into any, customDc *mapstructure.DecoderConfig) error {
 	dc := &mapstructure.DecoderConfig{
 		TagName:     "json",
 		ErrorUnused: true,

client/client_test.go

@@ -182,7 +182,7 @@ func TestSetCustomDecodeConfig(t *testing.T) {
 	h := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(http.StatusOK)
 		w.Header().Set("Content-Type", "application/json")
-		w.Write([]byte(fmt.Sprintf(`{"data": {"created_at":"%s"}}`, now.Format(time.RFC3339))))
+		fmt.Fprintf(w, `{"data": {"created_at":"%s"}}`, now.Format(time.RFC3339))
 	})
 
 	dc := &mapstructure.DecoderConfig{

client/options.go

@@ -36,7 +36,7 @@ func Path(url string) Option {
 }
 
 // AddHeader adds a header to the outgoing request. This is useful for setting expected Authentication headers for example.
-func AddHeader(key string, value string) Option {
+func AddHeader(key, value string) Option {
 	return func(bd *Request) {
 		bd.HTTP.Header.Add(key, value)
 	}

codegen/config/binder.go

@@ -61,7 +61,7 @@ func (b *Binder) FindTypeFromName(name string) (types.Type, error) {
 	return b.FindType(pkgName, typeName)
 }
 
-func (b *Binder) FindType(pkgName string, typeName string) (types.Type, error) {
+func (b *Binder) FindType(pkgName, typeName string) (types.Type, error) {
 	if pkgName == "" {
 		if typeName == "map[string]interface{}" {
 			return MapType, nil
@@ -123,7 +123,7 @@ func (b *Binder) DefaultUserObject(name string) (types.Type, error) {
 	return obj.Type(), nil
 }
 
-func (b *Binder) FindObject(pkgName string, typeName string) (types.Object, error) {
+func (b *Binder) FindObject(pkgName, typeName string) (types.Object, error) {
 	if pkgName == "" {
 		return nil, errors.New("package cannot be nil")
 	}
@@ -349,7 +349,7 @@ func isIntf(t types.Type) bool {
 
 func unwrapOmittable(t types.Type) (types.Type, bool) {
 	if t == nil {
-		return t, false
+		return nil, false
 	}
 	named, ok := t.(*types.Named)
 	if !ok {

codegen/config/config.go

@@ -644,7 +644,7 @@ func (tm TypeMap) ReferencedPackages() []string {
 	return pkgs
 }
 
-func (tm TypeMap) Add(name string, goType string) {
+func (tm TypeMap) Add(name, goType string) {
 	modelCfg := tm[name]
 	modelCfg.Model = append(modelCfg.Model, goType)
 	tm[name] = modelCfg

codegen/templates/templates.go

@@ -185,7 +185,7 @@ func parseTemplates(cfg Options, t *template.Template) (*template.Template, erro
 	return t, nil
 }
 
-func center(width int, pad string, s string) string {
+func center(width int, pad, s string) string {
 	if len(s)+2 > width {
 		return s
 	}

graphql/bool.go

@@ -15,7 +15,7 @@ func MarshalBoolean(b bool) Marshaler {
 func UnmarshalBoolean(v any) (bool, error) {
 	switch v := v.(type) {
 	case string:
-		return strings.ToLower(v) == "true", nil
+		return strings.EqualFold(v, "true"), nil
 	case int:
 		return v != 0, nil
 	case bool: