Skip to content

Commit 5c41a91

Browse files
samjwunileshnegi
authored andcommitted
[CI] Clone rccl and build from tip of develop (ROCm#99)
- Set cron to weekly - Remove unused properties - Try rccl install as sudo - Clear existing rccl repo - Run install with sudo and env vars - Fix path - Add rccl to path - Attempt to fix build and install of rccl during compile stage. - Remove existing clone from workspace - Fix path when install rccl - Fix path for install rccl-tests - Install rccl local only - Set RCCL_DIR - Build rccl and rccl-tests with cmake - Add extra env vars - Use installer instead of cmake for rccl - Update .jenkins/common.groovy - Get librccl.so from rccl/build/release - Switching job command to build rccl and rccl-tests using install.sh because those work properly together.
1 parent df26b32 commit 5c41a91

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

‎.jenkins/common.groovy‎

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,19 @@ def runCompileCommand(platform, project, jobName)
66
project.paths.construct_build_prefix()
77

88
String hipclangArgs = jobName.contains('hipclang') ? '--hip-clang' : ''
9-
def getRCCL = auxiliary.getLibrary('rccl',platform.jenkinsLabel,'develop')
109

1110
def command = """#!/usr/bin/env bash
1211
set -x
13-
${getRCCL}
12+
cd ${project.paths.build_prefix}
13+
git clone --recursive https://github.com/ROCm/rccl.git
14+
cd rccl
15+
./install.sh -l
16+
cd ../..
1417
${auxiliary.exitIfNotSuccess()}
18+
1519
cd ${project.paths.project_build_prefix}
16-
cmake \
17-
-DCMAKE_CXX_COMPILER=/opt/rocm/bin/hipcc \
18-
-S . -B build
19-
make -C build -j\$(nproc)
20+
export RCCL_DIR=\$(pwd)/../rccl/build/release
21+
./install.sh --rccl_home \$RCCL_DIR
2022
${auxiliary.exitIfNotSuccess()}
2123
"""
2224

‎.jenkins/precheckin.groovy‎

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -44,18 +44,16 @@ def runCI =
4444
ci: {
4545
String urlJobName = auxiliary.getTopJobName(env.BUILD_URL)
4646

47-
def propertyList = ["compute-rocm-dkms-no-npi":[pipelineTriggers([cron('0 1 * * 0')])],
48-
"compute-rocm-dkms-no-npi-hipclang":[pipelineTriggers([cron('0 1 * * 0')])],
49-
"rocm-docker":[]]
47+
def propertyList = [
48+
"compute-rocm-dkms-no-npi-hipclang":[pipelineTriggers([cron('0 * * * 6')])]
49+
]
5050
propertyList = auxiliary.appendPropertyList(propertyList)
5151

52-
def jobNameList = ["compute-rocm-dkms-no-npi":([ubuntu16:['rccl906']]),
53-
"rocm-docker":([ubuntu16:['rccl906']])]
54-
55-
jobNameList['compute-rocm-dkms-no-npi-hipclang'] = [ubuntu16:['rccl906']]
52+
def jobNameList = [
53+
"compute-rocm-dkms-no-npi-hipclang":([ubuntu16:['rccl906']])
54+
]
5655
jobNameList = auxiliary.appendJobNameList(jobNameList)
5756

58-
5957
propertyList.each
6058
{
6159
jobName, property->
@@ -75,9 +73,9 @@ ci: {
7573
// For url job names that are not listed by the jobNameList i.e. compute-rocm-dkms-no-npi-1901
7674
if(!jobNameList.keySet().contains(urlJobName))
7775
{
78-
properties(auxiliary.addCommonProperties([pipelineTriggers([cron('0 1 * * *')])]))
76+
properties(auxiliary.addCommonProperties([pipelineTriggers([cron('0 * * * 6')])]))
7977
stage(urlJobName) {
8078
runCI([ubuntu16:['rccl906']], urlJobName)
8179
}
8280
}
83-
}
81+
}

0 commit comments

Comments
 (0)