Skip to content

Commit f611dbd

Browse files
authored
Fix message size logging (ROCm#115)
Previously, the logger was logging the number of expected bytes a node was to recieve. This differs from the stdout logging, where the reported message size is the total size of a message. Signed-off-by: Grant Pinkert <gpinkert@amd.com>
1 parent 83d38d9 commit f611dbd

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

‎src/common.cu‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -760,12 +760,12 @@ testResult_t BenchTime(struct threadArgs* args, ncclDataType_t type, ncclRedOp_t
760760
PRINT(" %7s %6.2f %6.2f %5s", timeStr, algBw, busBw, "N/A");
761761
}
762762

763+
auto largestMessageSize = std::max(args->sendBytes, args->expectedBytes);
763764
if (args->reporter) {
764765
if (args->reportErrors) {
765-
args->reporter->addResult((args->nThreads * args->nGpus), args->nProcs, args->totalProcs, args->expectedBytes, in_place, timeUsec, algBw, busBw, wrongElts);
766-
}
767-
else {
768-
args->reporter->addResult((args->nThreads * args->nGpus), args->nProcs, args->totalProcs, args->expectedBytes, in_place, timeUsec, algBw, busBw);
766+
args->reporter->addResult((args->nThreads * args->nGpus), args->nProcs, args->totalProcs, largestMessageSize, in_place, timeUsec, algBw, busBw, wrongElts);
767+
} else {
768+
args->reporter->addResult((args->nThreads * args->nGpus), args->nProcs, args->totalProcs, largestMessageSize, in_place, timeUsec, algBw, busBw);
769769
}
770770
}
771771

0 commit comments

Comments
 (0)