prevent typing sound from playing when AI interacts with consoles (space-wizards#32906)

* prevent typing sound from playing when AI interacts with consoles

* cleanup

Author: MendaxxDev

Content.Shared/Sound/Components/EmitSoundOnUIOpenComponent.cs

@@ -1,3 +1,4 @@
+using Content.Shared.Whitelist;
 using Robust.Shared.GameStates;
 
 namespace Content.Shared.Sound.Components;
@@ -8,4 +9,9 @@ namespace Content.Shared.Sound.Components;
 [RegisterComponent, NetworkedComponent]
 public sealed partial class EmitSoundOnUIOpenComponent : BaseEmitSoundComponent
 {
+    /// <summary>
+    /// Blacklist for making the sound not play if certain entities open the UI
+    /// </summary>
+    [DataField]
+    public EntityWhitelist Blacklist = new();
 }

Content.Shared/Sound/SharedEmitSoundSystem.cs

@@ -58,7 +58,10 @@ public override void Initialize()
 
     private void HandleEmitSoundOnUIOpen(EntityUid uid, EmitSoundOnUIOpenComponent component, AfterActivatableUIOpenEvent args)
     {
-        TryEmitSound(uid, component, args.User);
+        if (_whitelistSystem.IsBlacklistFail(component.Blacklist, args.User))
+        {
+            TryEmitSound(uid, component, args.User);
+        }
     }
 
     private void OnMobState(Entity<SoundWhileAliveComponent> entity, ref MobStateChangedEvent args)

Resources/Prototypes/Entities/Mobs/Player/admin_ghost.yml

@@ -12,6 +12,7 @@
     - CanPilot
     - BypassInteractionRangeChecks
     - BypassDropChecks
+    - NoConsoleSound
   - type: Input
     context: "aghost"
   - type: Ghost

Resources/Prototypes/Entities/Mobs/Player/silicon.yml

@@ -374,6 +374,7 @@
     tags:
     - HideContextMenu
     - StationAi
+    - NoConsoleSound
 
 # Hologram projection that the AI's eye tracks.
 - type: entity

Resources/Prototypes/Entities/Structures/Machines/Computers/base_structurecomputers.yml

@@ -62,6 +62,9 @@
         volume: -1
         variation: 0.10
         pitch: 1.10  # low pitch keyboard sounds feel kinda weird
+    blacklist:
+      tags:
+      - NoConsoleSound
   - type: ContainerContainer
     containers:
       board: !type:Container

Resources/Prototypes/tags.yml

@@ -987,6 +987,9 @@
 - type: Tag
   id: NoBlockAnchoring
 
+- type: Tag
+  id: NoConsoleSound
+
 - type: Tag
   id: NozzleBackTank