Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: DataDog/sketches-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.4.6
Choose a base ref
...
head repository: DataDog/sketches-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.4.7
Choose a head ref
  • 6 commits
  • 17 files changed
  • 5 contributors

Commits on Aug 2, 2024

  1. Correct LICENSE to satisfy license checkers (#81) 

    Hello,

I've recently had an issue where the license classifier used by `go-licenses` (which is the Google standard license classifier) fails on this repository because the `LICENSE` file does not match the expected `Apache-2.0` format.

This fixes that, applying the standard Apache 2.0 license file instead.
    @RomainMuller
    RomainMuller authored Aug 2, 2024
    Configuration menu
    Copy the full SHA
    7546f8f View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2025

  1. Add efficient EncodeProto() with gostreamer 

    This PR pulls in protoc-gen-gostreamer which is a protobuf generator that allows you to convert between an application type
to protobuf directly to an io.Writer without allocating an intermediate protobuf struct in memory.

This has been used to great effect in the datadog agent to reduce intermediate allocations [here](DataDog/datadog-agent#18408), and we would like to do the same with ddsketches.

You can run `go test -bench='BenchmarkStreamVsRegularEncode' ./...` for a full comparison, but for certain sketches this makes a huge difference in allocations per encode.


```
BenchmarkStreamVsRegularEncode/buffered_paginated/log_normal_non_int_count/vanilla-10                 	   10000	    113276 ns/op	   67335 B/op	    2942 allocs/op
BenchmarkStreamVsRegularEncode/buffered_paginated/log_normal_non_int_count/gostreamer-10              	 6491349	       187.4 ns/op	     432 B/op	       6 allocs/op
```
    @leeavital
    leeavital committed Jan 16, 2025
    Configuration menu
    Copy the full SHA
    a7f6b8e View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2025

  1. Update ddsketch/ddsketch.go 

    Co-authored-by: Dario Castañé <dario.castane@datadoghq.com>
    @leeavital @darccio
    leeavital and darccio authored Feb 12, 2025
    Configuration menu
    Copy the full SHA
    75a54dd View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2025

  1. Encode positive and negative values as well

    @guyarb
    guyarb committed Feb 14, 2025
    Configuration menu
    Copy the full SHA
    ba6577e View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2025

  1. Update store.go

    @guyarb
    guyarb authored Feb 19, 2025
    Configuration menu
    Copy the full SHA
    4424210 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #82 from DataDog/lee.avital/gostreamer 

    Add efficient EncodeProto() with gostreamer
    @guyarb
    guyarb authored Feb 19, 2025
    Configuration menu
    Copy the full SHA
    cd8144a View commit details
    Browse the repository at this point in the history
Loading