Skip to content

Commit b942b62

Browse files
pattishinpattishin
authored
refactor: linting errors, updates to node 16 (#3464)
* refactor: updates samples to node 16 and resolves linting errors * fix: adding in a skip for the gaming samples as it is referencing a project that seems to either not exist or has strict permissions, preventing the tests from running refactor: move dataproc and media-livestream back to node 12
1 parent 190d545 commit b942b62

177 files changed

Lines changed: 253 additions & 272 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/workflows/game-servers-snippets.yaml‎

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -32,19 +32,22 @@ on:
3232
schedule:
3333
- cron: '0 0 * * 0'
3434
jobs:
35-
test:
36-
permissions:
37-
contents: 'read'
38-
id-token: 'write'
39-
if: github.event.action != 'labeled' || github.event.label.name == 'actions:force-run'
40-
uses: ./.github/workflows/test.yaml
41-
with:
42-
name: 'game-servers-snippets'
43-
path: 'game-servers/snippets'
35+
# -----------------
36+
# Issue to revisit skip: https://github.com/GoogleCloudPlatform/nodejs-docs-samples/issues/3466
37+
# -----------------
38+
# test:
39+
# permissions:
40+
# contents: 'read'
41+
# id-token: 'write'
42+
# if: github.event.action != 'labeled' || github.event.label.name == 'actions:force-run'
43+
# uses: ./.github/workflows/test.yaml
44+
# with:
45+
# name: 'game-servers-snippets'
46+
# path: 'game-servers/snippets'
4447
flakybot:
4548
permissions:
4649
contents: 'read'
4750
id-token: 'write'
4851
if: github.event_name == 'schedule' && always() # always() submits logs even if tests fail
4952
uses: ./.github/workflows/flakybot.yaml
50-
needs: [test]
53+
# needs: [test]

‎.kokoro/appengine/test-deployment/common.cfg‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ build_file: "nodejs-docs-samples/.kokoro/trampoline.sh"
1212
# Configure the docker image for kokoro-trampoline.
1313
env_vars: {
1414
key: "TRAMPOLINE_IMAGE"
15-
value: "gcr.io/cloud-devrel-kokoro-resources/node"
15+
value: "gcr.io/cloud-devrel-kokoro-resources/node:16-user"
1616
}
1717

1818
# Tell the trampoline which build file to use.

‎.kokoro/common.cfg‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ build_file: "nodejs-docs-samples/.kokoro/trampoline.sh"
1212
# Configure the docker image for kokoro-trampoline.
1313
env_vars: {
1414
key: "TRAMPOLINE_IMAGE"
15-
value: "gcr.io/cloud-devrel-kokoro-resources/node:14-user"
15+
value: "gcr.io/cloud-devrel-kokoro-resources/node:16-user"
1616
}
1717

1818
# Export XUnit test results for further analysis
1919
action {
2020
define_artifacts {
2121
regex: "**/*sponge_log.xml"
2222
}
23-
}
23+
}

‎.kokoro/functions/billing-periodic.cfg‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ env_vars: {
1515
# Configure the docker image for kokoro-trampoline.
1616
env_vars: {
1717
key: "TRAMPOLINE_IMAGE"
18-
value: "gcr.io/cloud-devrel-kokoro-resources/node:14-user"
18+
value: "gcr.io/cloud-devrel-kokoro-resources/node:16-user"
1919
}
2020

2121
# Tell the trampoline which build file to use.

‎.kokoro/functions/ocr-app.cfg‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ env_vars: {
99
# Configure the docker image for kokoro-trampoline.
1010
env_vars: {
1111
key: "TRAMPOLINE_IMAGE"
12-
value: "gcr.io/cloud-devrel-kokoro-resources/node:14-user"
12+
value: "gcr.io/cloud-devrel-kokoro-resources/node:16-user"
1313
}
1414

1515
# Tell the trampoline which build file to use.

‎.kokoro/run/common.cfg‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ env_vars: {
1818
# Configure the docker image for kokoro-trampoline.
1919
env_vars: {
2020
key: "TRAMPOLINE_IMAGE"
21-
value: "gcr.io/cloud-devrel-kokoro-resources/node:14-user"
21+
value: "gcr.io/cloud-devrel-kokoro-resources/node:16-user"
2222
}
2323

2424
# Export XUnit test results for further analysis

‎ai-platform/snippets/create-training-pipeline-image-classification.js‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,8 @@ function main(
8181
const request = {parent, trainingPipeline};
8282

8383
// Create training pipeline request
84-
const [response] = await pipelineServiceClient.createTrainingPipeline(
85-
request
86-
);
84+
const [response] =
85+
await pipelineServiceClient.createTrainingPipeline(request);
8786

8887
console.log('Create training pipeline image classification response');
8988
console.log(`Name : ${response.name}`);

‎ai-platform/snippets/create-training-pipeline-image-object-detection.js‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,8 @@ async function main(
7979
};
8080

8181
// Create training pipeline request
82-
const [response] = await pipelineServiceClient.createTrainingPipeline(
83-
request
84-
);
82+
const [response] =
83+
await pipelineServiceClient.createTrainingPipeline(request);
8584

8685
console.log('Create training pipeline image object detection response');
8786
console.log(`Name : ${response.name}`);

‎ai-platform/snippets/create-training-pipeline-tabular-classification.js‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,8 @@ async function main(
9393
};
9494

9595
// Create training pipeline request
96-
const [response] = await pipelineServiceClient.createTrainingPipeline(
97-
request
98-
);
96+
const [response] =
97+
await pipelineServiceClient.createTrainingPipeline(request);
9998

10099
console.log('Create training pipeline tabular classification response');
101100
console.log(`Name : ${response.name}`);

‎ai-platform/snippets/create-training-pipeline-tabular-regression.js‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,8 @@ async function main(
118118
};
119119

120120
// Create training pipeline request
121-
const [response] = await pipelineServiceClient.createTrainingPipeline(
122-
request
123-
);
121+
const [response] =
122+
await pipelineServiceClient.createTrainingPipeline(request);
124123

125124
console.log('Create training pipeline tabular regression response');
126125
console.log(`Name : ${response.name}`);

0 commit comments

Comments
 (0)