Skip to content

Commit 069033e

Browse files
authored
fix(devnet-sdk): multi-client; chain fork. (ethereum-optimism#16214)
When is nil, we first get the block number from the primary/first node and use that to compare with other nodes.
1 parent 7ace8ec commit 069033e

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

‎devnet-sdk/testing/systest/multi_client.go‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,14 @@ func (mc *MultiClient) HeaderByNumber(ctx context.Context, number *big.Int) (*ty
129129
}
130130

131131
header, err := mc.clients[0].HeaderByNumber(ctx, number)
132-
if err != nil || len(mc.clients) == 1 {
133-
return header, err
132+
if err != nil {
133+
return nil, err
134+
}
135+
if header == nil {
136+
return nil, fmt.Errorf("no header found for block number %v", number)
137+
}
138+
if len(mc.clients) == 1 {
139+
return header, nil
134140
}
135141

136142
// Verify consistency with retry for followers

0 commit comments

Comments
 (0)