table: fix br inside table causing early return (#150)

Author: JohannesKaufmann

plugin/table/2_collect.go

@@ -32,7 +32,7 @@ func hasProblematicChildNode(node *html.Node) bool {
 			// This will be caught with the newline check anyway.
 			// But we can safe some effort by aborting early...
 			return true
-		case "br", "hr", "ul", "ol", "blockquote":
+		case "hr", "ul", "ol", "blockquote":
 			return true
 		}
 
@@ -104,6 +104,8 @@ func (p *tablePlugin) collectTableContent(ctx converter.Context, node *html.Node
 			if containsNewline(cell) {
 				// Having newlines inside the content would break the table.
 				// So unfortunately we cannot convert the table.
+				//
+				// Note: We already trimmed the content earlier.
 				return nil
 			}
 		}

plugin/table/testdata/GoldenFiles/contents.in.html

@@ -18,6 +18,30 @@
   </tr>
 </table>
 
+<hr />
+
+<table>
+  <tr>
+    <td>
+      with break after
+      <br />
+    </td>
+  </tr>
+  <tr>
+    <td>
+      <br />
+      with break before
+    </td>
+  </tr>
+  <tr>
+    <td>
+      <br /><br /><br />
+      with break around
+      <br /><br /><br />
+    </td>
+  </tr>
+</table>
+
 <hr />
 <!-- yes: we can keep rendering a table (even though it contains a block node) -->
 

plugin/table/testdata/GoldenFiles/contents.out.md

@@ -5,6 +5,14 @@
 
 * * *
 
+|                   |
+|-------------------|
+| with break after  |
+| with break before |
+| with break around |
+
+* * *
+
 |                     |
 |---------------------|
 | Some normal content |