test stub for controller

Author: jonaslan

package.json

@@ -12,7 +12,7 @@
   },
   "scripts": {
     "//": "Gulp installs css and javascript",
-    "test": "echo \"TODO: Write some tests...\"",
+    "test": "mocha test/unit/*.js",
     "precommit": "standard && npm run test",
     "docker": "npm install --development && npm run build && npm prune --production",
     "build": "NODE_ENV=production gulp build",
@@ -32,26 +32,21 @@
     "jquery": "^3.1.0",
     "knockout": "^3.4.0",
     "knockout.viewmodel": "https://github.com/KTH/knockout.viewmodel.git#v2.0.3",
-    "kth-client-ajax": "https://github.com/KTH/kth-client-ajax.git#v1.0.2",
     "kth-client-logging": "https://github.com/KTH/kth-client-logging.git#v1.0.0",
-    "kth-node-access-log": "https://github.com/KTH/kth-node-access-log.git#v1.0.0",
+    "kth-node-access-log": "^0.2.0",
     "kth-node-api-call": "^1.2.2",
-    "kth-node-cache": "https://github.com/KTH/kth-node-cache.git#v1.0.0",
     "kth-node-configuration": "^1.4.0",
-    "kth-node-cortina-block": "^1.0.4",
     "kth-node-express-routing": "^0.3.1",
     "kth-node-i18n": "^1.0.2",
     "kth-node-ldap": "^2.0.1",
     "kth-node-log": "^2.0.3",
     "kth-node-monitor": "^0.1.5",
     "kth-node-passport-cas": "^2.0.0",
     "kth-node-redis": "^1.2.0",
-    "kth-node-response": "https://github.com/KTH/kth-node-response.git#v1.0.0",
     "kth-node-server": "^3.0.3",
     "kth-node-session": "^1.0.0",
     "kth-node-web-common": "^0.1.1",
     "kth-style": "^1.2.12",
-    "ldapjs": "^1.0.0",
     "locale": "^0.1.0",
     "passport": "^0.3.2",
     "safe-utils": "^0.1.1"
@@ -61,13 +56,17 @@
     "babel-loader": "^6.2.4",
     "babel-preset-es2015": "^6.9.0",
     "browser-sync": "^2.12.8",
+    "chai": "^4.0.2",
     "concurrently": "^2.1.0",
     "cross-env": "^2.0.0",
     "gulp": "^3.9.1",
     "husky": "^0.14.0",
     "kth-node-build-commons": "^3.0.0",
     "merge-stream": "^1.0.1",
     "mocha": "3.2.0",
+    "mockery": "^2.0.0",
+    "nock": "^9.0.13",
+    "node-mocks-http": "^1.6.3",
     "nodemon": "^1.11.0",
     "standard": "^7.1.1",
     "zombie": "5.0.5"

server/controllers/sampleCtrl.js

@@ -11,35 +11,17 @@ module.exports = {
 
 function * getIndex (req, res, next) {
   try {
-    let resp = {}
-    // safeGet returns the value after the return keyword if it exists, otherwise a default value
-    let apiUp = safeGet(() => { return api.sampleApi.connected }, false) // is our api up?
-
-    if (apiUp) {
-      const cachedApi = getCachedApi()
-      const client = cachedApi.client
-      const paths = cachedApi.paths
-      resp = yield client.getAsync(client.resolve(paths.getDataById.uri, { id: '123' }))
-    }
+    const client = api.nodeApi.client
+    const paths = api.nodeApi.paths
+    const resp = yield client.getAsync(client.resolve(paths.getDataById.uri, { id: '123' }), { useCache: true })
 
     res.render('sample/index', {
       debug: 'debug' in req.query,
       data: resp.statusCode === 200 ? safeGet(() => { return resp.body.name }) : '',
       error: resp.statusCode !== 200 ? safeGet(() => { return resp.body.message }) : ''
     })
   } catch (err) {
+    log.error('Error in getIndex', { error: err })
     next(err)
   }
 }
-
-/*
- * Get cache api, if not configured, use default api to avoid problems
- */
-function getCachedApi () {
-  if (api.sampleApiCached === undefined) {
-    log.info('No cached api configured, using deafult api')
-    return api.sampleApi
-  }
-
-  return api.sampleApiCached
-}

test/mocks/apipaths.json

@@ -0,0 +1,59 @@
+{
+  "system": {
+    "monitor": {
+      "uri": "/api/node/_monitor",
+      "method": "get"
+    },
+    "about": {
+      "uri": "/api/node/_about",
+      "method": "get"
+    },
+    "paths": {
+      "uri": "/api/node/_paths",
+      "method": "get"
+    },
+    "robots": {
+      "uri": "/robots.txt",
+      "method": "get"
+    },
+    "swagger": {
+      "uri": "/api/node/swagger.json",
+      "method": "get"
+    }
+  },
+  "api": {
+    "checkAPIkey": {
+      "uri": "/api/node/_checkAPIkey",
+      "method": "GET",
+      "apikey": {
+        "scope_required": true,
+        "scopes": [
+          "read"
+        ],
+        "type": "api_key"
+      }
+    },
+    "getDataById": {
+      "uri": "/api/node/v1/data/:id",
+      "method": "GET",
+      "apikey": {
+        "scope_required": true,
+        "scopes": [
+          "read"
+        ],
+        "type": "api_key"
+      }
+    },
+    "postDataById": {
+      "uri": "/api/node/v1/data/:id",
+      "method": "POST",
+      "apikey": {
+        "scope_required": true,
+        "scopes": [
+          "write"
+        ],
+        "type": "api_key"
+      }
+    }
+  }
+}

test/unit/test-sampleCtrl.js

@@ -0,0 +1,48 @@
+/* eslint-env mocha */
+/* eslint-disable no-unused-expressions */
+
+process.env['LDAP_URI'] = 'ldaps://mockuser@mockdomain.com@mockldapdomain.com'
+process.env['LDAP_PASSWORD'] = 'mockldappassword'
+const expect = require('chai').expect
+const nock = require('nock')
+const mockery = require('mockery')
+const httpMocks = require('node-mocks-http')
+
+const mockLogger = {}
+mockLogger.debug = mockLogger.info = mockLogger.error = mockLogger.warn = console.log
+mockLogger.init = () => {}
+
+mockery.registerMock('kth-node-log', mockLogger)
+mockery.enable({
+  warnOnReplace: false,
+  warnOnUnregistered: false
+})
+
+const paths = require('../mocks/apipaths.json')
+const api = nock('http://localhost:3001/api/node')
+  .get('/_paths')
+  .reply(200, paths)
+  .get('/_checkAPIkey')
+  .reply(200, {})
+
+describe('Index page', function () {
+  before((done) => {
+    require('../../server/api')
+    setTimeout(() => {
+      done()
+    }, 500)
+  })
+  it('should get the index page', done => {
+    api.get('/v1/data/123').reply(200, {
+      id: '123',
+      name: 'asdasd'
+    })
+    const ctrl = require('../../server/controllers/sampleCtrl')
+    const { req, res } = httpMocks.createMocks()
+    res.render = function (view, data) {
+      expect(data).to.be.not.undefined
+      done()
+    }
+    ctrl.getIndex(req, res, console.log)
+  })
+})