fix(api keys): Query API Keys correctly returns valid API key name if not present (elastic#234083)

Closes elastic#234194 

## Summary

Reintroduces fallback for API Keys with null names which was causing the
API Keys page to break

### Release notes
Fixes a potential bug on the API Keys Management page when trying to
load API keys with null names.

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Author: 2 people

x-pack/platform/plugins/shared/security/server/routes/api_keys/query.test.ts

@@ -227,4 +227,42 @@ describe('Query API Keys route', () => {
       );
     });
   });
+
+  describe('validate API Key names', () => {
+    it('should substitute an empty string for keys with `null` names', async () => {
+      esClientMock.asCurrentUser.security.queryApiKeys.mockRestore();
+      esClientMock.asCurrentUser.security.queryApiKeys.mockResponse({
+        api_keys: [
+          { id: 'with_name', name: 'foo', invalidated: false },
+          { id: 'undefined_name', invalidated: false },
+          { id: 'null_name', name: null, invalidated: false },
+        ],
+      } as any);
+
+      const response = await routeHandler(
+        mockContext,
+        httpServerMock.createKibanaRequest(),
+        kibanaResponseFactory
+      );
+
+      expect(response.status).toBe(200);
+      expect(response.payload.apiKeys).toEqual([
+        {
+          id: 'with_name',
+          name: 'foo',
+          invalidated: false,
+        },
+        {
+          id: 'undefined_name',
+          name: 'undefined_name',
+          invalidated: false,
+        },
+        {
+          id: 'null_name',
+          name: 'null_name',
+          invalidated: false,
+        },
+      ]);
+    });
+  });
 });

x-pack/platform/plugins/shared/security/server/routes/api_keys/query.ts

@@ -5,6 +5,8 @@
  * 2.0.
  */
 
+import type { SecurityApiKey } from '@elastic/elasticsearch/lib/api/types';
+
 import { schema } from '@kbn/config-schema';
 import type { QueryApiKeyResult } from '@kbn/security-plugin-types-common';
 
@@ -16,6 +18,15 @@ interface QueryClause {
   [key: string]: any;
 }
 
+const transformAPIKeyNames = (keys: SecurityApiKey[]) => {
+  return keys.map((key) => {
+    if (!key.name) {
+      key.name = key.id;
+    }
+    return key;
+  });
+};
+
 export function defineQueryApiKeysAndAggregationsRoute({
   router,
   getAuthenticationService,
@@ -165,7 +176,7 @@ export function defineQueryApiKeysAndAggregationsRoute({
 
           queryResult = {
             // @ts-expect-error Elasticsearch client types do not know about Cross-Cluster API keys yet.
-            apiKeys: queryResponse.api_keys,
+            apiKeys: transformAPIKeyNames(queryResponse.api_keys),
             total: queryResponse.total,
             count: queryResponse.api_keys.length,
           };