[#noissue] Cleanup

Author: intr3p1d

exceptiontrace/exceptiontrace-collector/src/main/java/com/navercorp/pinpoint/exceptiontrace/collector/dao/PinotExceptionTraceDao.java

@@ -40,6 +40,7 @@
 @Repository
 public class PinotExceptionTraceDao implements ExceptionTraceDao {
     private final Logger logger = LogManager.getLogger(this.getClass());
+    private final boolean isDebugEnabled = logger.isDebugEnabled();
 
     private final KafkaTemplate<String, ExceptionMetaDataEntity> kafkaExceptionMetaDataTemplate;
 
@@ -64,11 +65,16 @@ public PinotExceptionTraceDao(
     @Override
     public void insert(List<ExceptionMetaData> exceptionMetaData) {
         Objects.requireNonNull(exceptionMetaData);
-        logger.info("Pinot data insert: {}", exceptionMetaData);
+
+        if (isDebugEnabled) {
+            logger.debug("Pinot data insert: {}", exceptionMetaData);
+        }
 
         for (ExceptionMetaData e : exceptionMetaData) {
             ExceptionMetaDataEntity dataEntity = mapper.toEntity(e);
-            logger.info("data insert {}", dataEntity);
+            if (isDebugEnabled) {
+                logger.debug("data insert {}", dataEntity);
+            }
             CompletableFuture<SendResult<String, ExceptionMetaDataEntity>> response = this.kafkaExceptionMetaDataTemplate.send(
                     topic, dataEntity
             );

exceptiontrace/exceptiontrace-web/src/test/java/com/navercorp/pinpoint/exceptiontrace/web/model/ExceptionTraceValueViewTest.java

@@ -16,23 +16,21 @@ void testGetFieldName() {
         GroupedFieldName emptyFieldName = new GroupedFieldName();
         emptyFieldName.setErrorMessage("");
         view.setGroupedFieldName(emptyFieldName);
-
         assertEquals(ExceptionTraceValueView.EMPTY_STRING, view.getFieldName());
 
+
         GroupedFieldName nullStringFieldName = new GroupedFieldName();
-        emptyFieldName.setErrorMessage("null");
-        view.setGroupedFieldName(emptyFieldName);
+        nullStringFieldName.setErrorMessage("null");
+        view.setGroupedFieldName(nullStringFieldName);
+        assertEquals("null", view.getFieldName());
 
-        assertEquals(ExceptionTraceValueView.EMPTY_STRING, view.getFieldName());
 
         GroupedFieldName nullFieldName = new GroupedFieldName();
         view.setGroupedFieldName(nullFieldName);
-
         assertEquals(ExceptionTraceValueView.TOTAL_FIELDNAME, view.getFieldName());
 
 
         view.setGroupedFieldName(null);
-
         assertEquals(ExceptionTraceValueView.TOTAL_FIELDNAME, view.getFieldName());
     }
 }