fix: ensure both Linux x86_64 and ARM64 wheels are built#162
Merged
Conversation
Use matrix include-only strategy to explicitly define all 5 platforms: - Linux x86_64 - Linux ARM64 (aarch64) - macOS x86_64 (Intel) - macOS ARM64 (Apple Silicon) - Windows x86_64 Previous matrix config with 'os' array + 'include' caused GitHub Actions to only run 4 jobs instead of 5, missing one of the Linux builds.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a GitHub Actions matrix configuration issue that prevented all 5 platform-specific wheels from being built. The previous configuration combined a matrix os array with include entries, which caused GitHub Actions to only execute 4 jobs instead of the intended 5, missing one of the Linux builds.
Key Changes
- Removed the matrix
osandpython-versionarray definitions - Converted to an include-only matrix strategy with explicit platform configurations
- Added
python-version: "3.13"to each of the 5 platform entries
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use matrix include-only strategy to explicitly define all 5 platforms:
Previous matrix config with 'os' array + 'include' caused GitHub Actions to only run 4 jobs instead of 5, missing one of the Linux builds.