Skip to content

fix: add chat() API and stop misusing summarize()#208

Merged
evan-ak merged 3 commits intoNevaMind-AI:mainfrom
summerx96:fix/chat-vs-summarize
Feb 6, 2026
Merged

fix: add chat() API and stop misusing summarize()#208
evan-ak merged 3 commits intoNevaMind-AI:mainfrom
summerx96:fix/chat-vs-summarize

Conversation

@summerx96
Copy link
Contributor

Summary

Separates general instruction-following from summarization so non-summary prompts no longer get a default "Summarize …" system instruction.

Why

Structured extraction/ranking prompts were being sent through summarize(), which injects a default summarization system prompt when system_prompt is omitted. That causes the model to summarize instructions instead of executing them and leads to silent parse failures.

Changes

  • Add chat() to SDK + HTTP LLM clients and wrapper.
  • Switch non-summary call sites to chat() in memorize/retrieve/patch/crud.
  • Fix _summarize_segment() to pass segment text + summary system prompt.

Tests

  • Not run standalone for this PR; end-to-end run on the stacked branch (feat/gemini-httpx) with Gemini.

Note

If possible, please preserve commit authorship (avoid rewriting author) for contribution attribution.

@summerx96 summerx96 changed the title Add chat() API and stop misusing summarize() Jan 10, 2026
@summerx96 summerx96 force-pushed the fix/chat-vs-summarize branch from 931d040 to 6c4e6da Compare January 11, 2026 06:11
@summerx96 summerx96 force-pushed the fix/chat-vs-summarize branch from 6c4e6da to 5bf951e Compare January 13, 2026 12:38
@evan-ak evan-ak merged commit be0a5c7 into NevaMind-AI:main Feb 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants