Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/rust.vim
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Notgnoshi/rust.vim
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 3 files changed
  • 3 contributors

Commits on Feb 16, 2024

  1. Ignore cargo messages like Blocking waiting for ...

    Whenever Cargo tries to build a project while there is another build in
    progress, Cargo will wait for the other build to finish, and print
    messages like this:
    
    ```
    Blocking waiting for file lock on package cache
    Blocking waiting for file lock on package cache
    Blocking waiting for file lock on build directory
    ```
    
    Those messages were not ignored, and were therefore included in the
    quickfix, making it look like there were some issues even if the build
    succeeded.
    
    This commit configures `&errorformat` to ignore those messages and avoid
    including them in the quickfix.
    
    Closes #499 .
    dimonomid authored and Notgnoshi committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    089aba1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d5f1ae View commit details
    Browse the repository at this point in the history
  3. Prepend cargo's errorformat to rustc's errorformat

    Most of the Cargo errorformat patterns are patterns that should be
    _stripped out_, which means we want to put them at the beginning of the
    errorformat list, otherwise they might be included in loose %C rules.
    Notgnoshi committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    21cc07b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3490ea3 View commit details
    Browse the repository at this point in the history
  5. Remove INFO note: pattern

    This adds a quickfix entry for every note:, which is quite confusing,
    especially when they're embedded in a larger error.
    Notgnoshi committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    85972c7 View commit details
    Browse the repository at this point in the history
  6. Improve thread panic and assertion failure patterns

    The
        %E  left:%m,
        %C right:%m %f:%l:%c
        %Z
    set of patterns was pretty frustrating. The quickfix list entry had just
    the LHS value as the message, and was lacking %f:%l%c to allow you to
    jump to the failure. The RHS pattern currently (with Rust 1.74) doesn't
    print the %f:%l:%c location, so it wasn't being included in the entry.
    
    This is all replaced by a better rule
    
        %+E.*panicked at %f:%l:%c:
        %+Cassertion.*
    
    Which creates a _much_ better error message for :clist
    
    * For panics not triggered by assertions, at least there's still an
      error message of "... panicked ..."
    * For panics that are assertions, the kind of assertion (assert_eq! or
      assert!) is printed, but not the assertion values (because that can
      make the error message become very unwieldy)
    
    This can be tested by saving the contents of a Cargo run (either build
    or test) to a file
    
        # Use .rs so that the Rust errorformat rules get used
        $ cargo build |& tee -a build-output.rs
        $ cargo test |& tee -a test-output.rs
        $ vim build-output.rs
        " This is the magic. Load the quickfix list from the current buffer.
        :cgetbuffer
        :clist
        :copen
    Notgnoshi committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    58fe7ac View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2025

  1. Fix ugly Error highlighting on fenced code blocks in attributes

    The following code
    
        #[cfg_attr(feature = "doc-diagrams", doc = svgbobdoc::transform!(
        /// ```svgbob
        /// ...
        /// ```
        ))]
    
    had the whole doc comment highlighted as rustCommentLineDocError, which
    was quite ugly.
    
    I don't think this is the correct fix for the issue, but I really
    struggled to understand and extend the rustComment.*RustCode regions to
    work inside the rustAttributeContents cluster.
    
    This at least makes it less ugly for now.
    Notgnoshi committed Apr 21, 2025
    Configuration menu
    Copy the full SHA
    397737e View commit details
    Browse the repository at this point in the history
Loading