-
Notifications
You must be signed in to change notification settings - Fork 311
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: rust-lang/rust.vim
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: Notgnoshi/rust.vim
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 7 commits
- 3 files changed
- 3 contributors
Commits on Feb 16, 2024
-
Ignore cargo messages like Blocking waiting for ...
Whenever Cargo tries to build a project while there is another build in progress, Cargo will wait for the other build to finish, and print messages like this: ``` Blocking waiting for file lock on package cache Blocking waiting for file lock on package cache Blocking waiting for file lock on build directory ``` Those messages were not ignored, and were therefore included in the quickfix, making it look like there were some issues even if the build succeeded. This commit configures `&errorformat` to ignore those messages and avoid including them in the quickfix. Closes #499 .
Configuration menu - View commit details
-
Copy full SHA for 089aba1 - Browse repository at this point
Copy the full SHA 089aba1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d5f1ae - Browse repository at this point
Copy the full SHA 9d5f1aeView commit details -
Prepend cargo's errorformat to rustc's errorformat
Most of the Cargo errorformat patterns are patterns that should be _stripped out_, which means we want to put them at the beginning of the errorformat list, otherwise they might be included in loose %C rules.
Configuration menu - View commit details
-
Copy full SHA for 21cc07b - Browse repository at this point
Copy the full SHA 21cc07bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3490ea3 - Browse repository at this point
Copy the full SHA 3490ea3View commit details -
This adds a quickfix entry for every note:, which is quite confusing, especially when they're embedded in a larger error.
Configuration menu - View commit details
-
Copy full SHA for 85972c7 - Browse repository at this point
Copy the full SHA 85972c7View commit details -
Improve thread panic and assertion failure patterns
The %E left:%m, %C right:%m %f:%l:%c %Z set of patterns was pretty frustrating. The quickfix list entry had just the LHS value as the message, and was lacking %f:%l%c to allow you to jump to the failure. The RHS pattern currently (with Rust 1.74) doesn't print the %f:%l:%c location, so it wasn't being included in the entry. This is all replaced by a better rule %+E.*panicked at %f:%l:%c: %+Cassertion.* Which creates a _much_ better error message for :clist * For panics not triggered by assertions, at least there's still an error message of "... panicked ..." * For panics that are assertions, the kind of assertion (assert_eq! or assert!) is printed, but not the assertion values (because that can make the error message become very unwieldy) This can be tested by saving the contents of a Cargo run (either build or test) to a file # Use .rs so that the Rust errorformat rules get used $ cargo build |& tee -a build-output.rs $ cargo test |& tee -a test-output.rs $ vim build-output.rs " This is the magic. Load the quickfix list from the current buffer. :cgetbuffer :clist :copenConfiguration menu - View commit details
-
Copy full SHA for 58fe7ac - Browse repository at this point
Copy the full SHA 58fe7acView commit details
Commits on Apr 21, 2025
-
Fix ugly Error highlighting on fenced code blocks in attributes
The following code #[cfg_attr(feature = "doc-diagrams", doc = svgbobdoc::transform!( /// ```svgbob /// ... /// ``` ))] had the whole doc comment highlighted as rustCommentLineDocError, which was quite ugly. I don't think this is the correct fix for the issue, but I really struggled to understand and extend the rustComment.*RustCode regions to work inside the rustAttributeContents cluster. This at least makes it less ugly for now.Configuration menu - View commit details
-
Copy full SHA for 397737e - Browse repository at this point
Copy the full SHA 397737eView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master