Do not create tables when in read-only mode - #128
Merged
Conversation
If db was opened with flag='r', check if tablename exists, if not raise RuntimeError.
piskvorky
requested changes
Jan 4, 2021
Update RuntimeError message per @piskvorky's suggestion Co-authored-by: Radim Řehůřek <me@radimrehurek.com>
mpenkov
reviewed
Jan 8, 2021
mpenkov
left a comment
mpenkov
left a comment
Collaborator
There was a problem hiding this comment.
The changes look good. Is there a way to unit-test these changes?
Having a test would help us prevent regressions in the future.
Opening a SqliteDict in read-only mode should not create a new table, only raise RuntimeError.
Contributor
Author
|
I included a basic test. |
mpenkov
approved these changes
Jan 9, 2021
Collaborator
|
Good work @hholst80 ! Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If db was opened with flag='r', check if tablename exists, if not raise RuntimeError.
Closes #127