Skip to content

Commit 7e68c3d

Browse files
author
AaronCasas
authored
[DATA-646] API changes for keyset pagination; make fields that should never be negative uints. (viamrobotics#94)
expected breaking changes as per @AaronCasas
1 parent e1ecc29 commit 7e68c3d

8 files changed

Lines changed: 789 additions & 435 deletions

File tree

‎app/data/v1/data.pb.go‎

Lines changed: 360 additions & 263 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎app/datasync/v1/data_sync.pb.go‎

Lines changed: 143 additions & 120 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎gen/js/app/data/v1/data_pb.d.ts‎

Lines changed: 28 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,15 @@ export class DataRequest extends jspb.Message {
1212
getFilter(): Filter | undefined;
1313
setFilter(value?: Filter): void;
1414

15-
getSkip(): number;
16-
setSkip(value: number): void;
17-
1815
getLimit(): number;
1916
setLimit(value: number): void;
2017

18+
getLast(): string;
19+
setLast(value: string): void;
20+
21+
getSortOrder(): OrderMap[keyof OrderMap];
22+
setSortOrder(value: OrderMap[keyof OrderMap]): void;
23+
2124
serializeBinary(): Uint8Array;
2225
toObject(includeInstance?: boolean): DataRequest.AsObject;
2326
static toObject(includeInstance: boolean, msg: DataRequest): DataRequest.AsObject;
@@ -31,8 +34,9 @@ export class DataRequest extends jspb.Message {
3134
export namespace DataRequest {
3235
export type AsObject = {
3336
filter?: Filter.AsObject,
34-
skip: number,
3537
limit: number,
38+
last: string,
39+
sortOrder: OrderMap[keyof OrderMap],
3640
}
3741
}
3842

@@ -249,6 +253,9 @@ export class TabularDataByFilterResponse extends jspb.Message {
249253
getCount(): number;
250254
setCount(value: number): void;
251255

256+
getLast(): string;
257+
setLast(value: string): void;
258+
252259
serializeBinary(): Uint8Array;
253260
toObject(includeInstance?: boolean): TabularDataByFilterResponse.AsObject;
254261
static toObject(includeInstance: boolean, msg: TabularDataByFilterResponse): TabularDataByFilterResponse.AsObject;
@@ -264,6 +271,7 @@ export namespace TabularDataByFilterResponse {
264271
metadataList: Array<CaptureMetadata.AsObject>,
265272
dataList: Array<TabularData.AsObject>,
266273
count: number,
274+
last: string,
267275
}
268276
}
269277

@@ -372,6 +380,9 @@ export class BinaryDataByFilterResponse extends jspb.Message {
372380
getCount(): number;
373381
setCount(value: number): void;
374382

383+
getLast(): string;
384+
setLast(value: string): void;
385+
375386
serializeBinary(): Uint8Array;
376387
toObject(includeInstance?: boolean): BinaryDataByFilterResponse.AsObject;
377388
static toObject(includeInstance: boolean, msg: BinaryDataByFilterResponse): BinaryDataByFilterResponse.AsObject;
@@ -386,6 +397,7 @@ export namespace BinaryDataByFilterResponse {
386397
export type AsObject = {
387398
dataList: Array<BinaryData.AsObject>,
388399
count: number,
400+
last: string,
389401
}
390402
}
391403

@@ -424,6 +436,9 @@ export class BinaryDataByIDsResponse extends jspb.Message {
424436
getCount(): number;
425437
setCount(value: number): void;
426438

439+
getLast(): string;
440+
setLast(value: string): void;
441+
427442
serializeBinary(): Uint8Array;
428443
toObject(includeInstance?: boolean): BinaryDataByIDsResponse.AsObject;
429444
static toObject(includeInstance: boolean, msg: BinaryDataByIDsResponse): BinaryDataByIDsResponse.AsObject;
@@ -438,6 +453,7 @@ export namespace BinaryDataByIDsResponse {
438453
export type AsObject = {
439454
dataList: Array<BinaryData.AsObject>,
440455
count: number,
456+
last: string,
441457
}
442458
}
443459

@@ -617,3 +633,11 @@ export namespace DeleteBinaryDataByIDsResponse {
617633
}
618634
}
619635

636+
export interface OrderMap {
637+
ORDER_UNSPECIFIED: 0;
638+
ORDER_DESCENDING: 1;
639+
ORDER_ASCENDING: 2;
640+
}
641+
642+
export const Order: OrderMap;
643+

0 commit comments

Comments
 (0)