Added minor linter fixes. (google#311)

* Added Minor linter fixes.

* More typos

* upd

Author: dpasiukevich

agent/llmagent/llmagent_saveoutput_test.go

@@ -119,11 +119,11 @@ func TestLlmAgent_MaybeSaveOutputToState(t *testing.T) {
 			// The method modifies the event in-place, just like the Python version.
 			createdAgent, err := New(tc.agentConfig)
 			if err != nil {
-				t.Fatal("failed to create agent: %w", err)
+				t.Fatalf("failed to create agent: %v", err)
 			}
 			createdLlmAgent, ok := createdAgent.(*llmAgent)
 			if !ok {
-				t.Fatal("failed to create agent: %w", err)
+				t.Fatalf("failed to convert to llmagent")
 			}
 			createdLlmAgent.maybeSaveOutputToState(tc.event)
 

artifact/request_validation_test.go

@@ -102,7 +102,7 @@ func TestSaveRequest_Validate(t *testing.T) {
 				Part:      genai.NewPartFromFunctionCall("example", nil),
 			},
 			wantErr:    true,
-			wantErrMsg: "invalid save request: Part.InlineData or Part.Text have to be set",
+			wantErrMsg: "invalid save request: Part.InlineData or Part.Text has to be set",
 		},
 		{
 			name:       "Completely empty request",

artifact/service.go

@@ -56,7 +56,7 @@ type SaveRequest struct {
 	// Part is the artifact to store.
 	Part *genai.Part
 
-	// Belows are optional fields.
+	// Below are optional fields.
 
 	// If set, the artifact will be saved with this version.
 	// If unset, a new version will be created.
@@ -75,7 +75,7 @@ func validateRequiredStrings(fields []requiredField) []string {
 	return missingFields
 }
 
-// Validate checks if the struct is valid or if its missing field
+// Validate checks if the struct is valid or if it is missing fields.
 func (req *SaveRequest) Validate() error {
 	// Define the fields to check in the desired order
 	fieldsToCheck := []requiredField{
@@ -99,7 +99,7 @@ func (req *SaveRequest) Validate() error {
 	}
 
 	if req.Part.Text == "" && req.Part.InlineData == nil {
-		return fmt.Errorf("invalid save request: Part.InlineData or Part.Text have to be set")
+		return fmt.Errorf("invalid save request: Part.InlineData or Part.Text has to be set")
 	}
 	return nil
 }
@@ -113,11 +113,11 @@ type SaveResponse struct {
 type LoadRequest struct {
 	AppName, UserID, SessionID, FileName string
 
-	// Belows are optional fields.
+	// Below are optional fields.
 	Version int64
 }
 
-// Validate checks if the struct is valid or if its missing field
+// Validate checks if the struct is valid or if it is missing fields.
 func (req *LoadRequest) Validate() error {
 	// Define the fields to check in the desired order
 	fieldsToCheck := []requiredField{
@@ -147,11 +147,11 @@ type LoadResponse struct {
 type DeleteRequest struct {
 	AppName, UserID, SessionID, FileName string
 
-	// Belows are optional fields.
+	// Below are optional fields.
 	Version int64
 }
 
-// Validate checks if the struct is valid or if its missing field
+// Validate checks if the struct is valid or if it is missing fields.
 func (req *DeleteRequest) Validate() error {
 	// Define the fields to check in the desired order
 	fieldsToCheck := []requiredField{
@@ -176,7 +176,7 @@ type ListRequest struct {
 	AppName, UserID, SessionID string
 }
 
-// Validate checks if the struct is valid or if its missing field
+// Validate checks if the struct is valid or if it is missing a field.
 func (req *ListRequest) Validate() error {
 	// Define the fields to check in the desired order
 	fieldsToCheck := []requiredField{

cmd/adkgo/internal/deploy/deploy.go

@@ -20,7 +20,7 @@ import (
 	"google.golang.org/adk/cmd/adkgo/internal/root"
 )
 
-// deployCmd represents the deploy command.
+// DeployCmd represents the deploy command.
 var DeployCmd = &cobra.Command{
 	Use:   "deploy",
 	Short: "Makes deployment to various platforms easy",

cmd/launcher/web/api/api.go

@@ -77,6 +77,7 @@ func (a *apiLauncher) SetupSubrouters(router *mux.Router, config *launcher.Confi
 	router.Methods("GET", "POST", "DELETE", "OPTIONS").PathPrefix("/api/").Handler(
 		http.StripPrefix("/api", corsHandler),
 	)
+
 	return nil
 }
 

cmd/launcher/web/webui/webui.go

@@ -30,7 +30,7 @@ import (
 	"google.golang.org/adk/server/adkrest/controllers"
 )
 
-// webUIConfig contains parametres for lauching ADK Web UI
+// webUIConfig contains parameters for launching ADK Web UI
 type webUIConfig struct {
 	backendAddress string
 	pathPrefix     string
@@ -52,7 +52,7 @@ func (w *webUILauncher) Keyword() string {
 	return "webui"
 }
 
-// Parse implements web.Sublauncher. After parsing webui-specific arguments returns remaining un-parsed arguments
+// Parse implements web.Sublauncher. After parsing webui-specific arguments returns remaining unparsed arguments
 func (w *webUILauncher) Parse(args []string) ([]string, error) {
 	err := w.flags.Parse(args)
 	if err != nil || !w.flags.Parsed() {

examples/README.md

@@ -8,7 +8,7 @@ This folder hosts examples to test different features. The examples are usually
 # Launcher
 In many examples you can see such lines:
 ```go
-l := full.NewLaucher()
+l := full.NewLauncher()
 err = l.ParseAndRun(ctx, config, os.Args[1:], universal.ErrorOnUnparsedArgs)
 if err != nil {
     log.Fatalf("run failed: %v\n\n%s", err, l.FormatSyntax())
@@ -24,4 +24,4 @@ it allows to to decide, which launching options are supported in the run-time.
 
 Run `go run ./example/quickstart/main.go help` for details
 
-As an alternative, you may want to use `prod.NewLaucher()` which only builds-in restapi and a2a launchers.
+As an alternative, you may want to use `prod.NewLauncher()` which only builds-in restapi and a2a launchers.

examples/web/agents/llmauditor.go

@@ -67,7 +67,7 @@ There are various actions you can take to help you with the verification:
   * You may search the web to find information that supports or contradicts the claim.
   * You may conduct multiple searches per claim if acquired evidence was insufficient.
   * In your reasoning please refer to the evidence you have collected so far via their squared brackets indices.
-  * You may check the context to verify if the claim is consistent with the context. Read the context carefully to idenfity specific user instructions that the text should follow, facts that the text should be faithful to, etc.
+  * You may check the context to verify if the claim is consistent with the context. Read the context carefully to identify specific user instructions that the text should follow, facts that the text should be faithful to, etc.
   * You should draw your final conclusion on the entire text after you acquired all the information you needed.
 
 # Output format
@@ -217,7 +217,7 @@ func afterReviser(ctx agent.CallbackContext, llmResponse *model.LLMResponse, llm
 	return llmResponse, nil
 }
 
-func GetLLmAuditorAgent(ctx context.Context, model model.LLM) agent.Agent {
+func GetLLMAuditorAgent(ctx context.Context, model model.LLM) agent.Agent {
 	criticAgent, err := llmagent.New(llmagent.Config{
 		Model:       model,
 		Name:        "critic_agent",

examples/web/main.go

@@ -48,11 +48,12 @@ func saveReportfunc(ctx agent.CallbackContext, llmResponse *model.LLMResponse, l
 	return llmResponse, llmResponseError
 }
 
-// needed to use 'user' for both a2a and webui (which are sharing the same sessions service)
+// AuthInterceptor sets 'user' name needed for both a2a and webui launchers which sharing the same sessions service.
 type AuthInterceptor struct {
 	a2asrv.PassthroughCallInterceptor
 }
 
+// Before implements a before request callback.
 func (a *AuthInterceptor) Before(ctx context.Context, callCtx *a2asrv.CallContext, req *a2asrv.Request) (context.Context, error) {
 	callCtx.User = &a2asrv.AuthenticatedUser{
 		UserName: "user",
@@ -84,7 +85,7 @@ func main() {
 	if err != nil {
 		log.Fatalf("Failed to create agent: %v", err)
 	}
-	llmAuditor := agents.GetLLmAuditorAgent(ctx, model)
+	llmAuditor := agents.GetLLMAuditorAgent(ctx, model)
 	imageGeneratorAgent := agents.GetImageGeneratorAgent(ctx, model)
 
 	agentLoader, err := agent.NewMultiLoader(

go.mod

@@ -16,6 +16,7 @@ require (
 
 require (
 	github.com/google/jsonschema-go v0.3.0
+	github.com/google/safehtml v0.1.0
 	github.com/modelcontextprotocol/go-sdk v0.7.0
 	google.golang.org/grpc v1.76.0
 	gorm.io/driver/sqlite v1.6.0