Skip to content

Commit b1cffa7

Browse files
roberto-aguilarsvpernova09
authored andcommitted
Rename make command's default name property (laravel#682)
The previous name will conflict with the symfony/console in its 3.4.x version and given that this was just for internal use, it was renamed.
1 parent 90d7043 commit b1cffa7

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

‎src/MakeCommand.php‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class MakeCommand extends Command
3333
*
3434
* @var string
3535
*/
36-
protected $defaultName;
36+
protected $defaultProjectName;
3737

3838
/**
3939
* Configure the command options.
@@ -44,13 +44,13 @@ protected function configure()
4444
{
4545
$this->basePath = getcwd();
4646
$this->projectName = basename($this->basePath);
47-
$this->defaultName = $this->slug($this->projectName);
47+
$this->defaultProjectName = $this->slug($this->projectName);
4848

4949
$this
5050
->setName('make')
5151
->setDescription('Install Homestead into the current project')
52-
->addOption('name', null, InputOption::VALUE_OPTIONAL, 'The name of the virtual machine.', $this->defaultName)
53-
->addOption('hostname', null, InputOption::VALUE_OPTIONAL, 'The hostname of the virtual machine.', $this->defaultName)
52+
->addOption('name', null, InputOption::VALUE_OPTIONAL, 'The name of the virtual machine.', $this->defaultProjectName)
53+
->addOption('hostname', null, InputOption::VALUE_OPTIONAL, 'The hostname of the virtual machine.', $this->defaultProjectName)
5454
->addOption('ip', null, InputOption::VALUE_OPTIONAL, 'The IP address of the virtual machine.')
5555
->addOption('no-after', null, InputOption::VALUE_NONE, 'Determines if the after.sh file is not created.')
5656
->addOption('no-aliases', null, InputOption::VALUE_NONE, 'Determines if the aliases file is not created.')
@@ -206,8 +206,8 @@ protected function createSettingsFile($format, $options)
206206
}
207207

208208
$settings->updateIpAddress($options['ip'])
209-
->configureSites($this->projectName, $this->defaultName)
210-
->configureSharedFolders($this->basePath, $this->defaultName)
209+
->configureSites($this->projectName, $this->defaultProjectName)
210+
->configureSharedFolders($this->basePath, $this->defaultProjectName)
211211
->save("{$this->basePath}/Homestead.{$format}");
212212
}
213213

0 commit comments

Comments
 (0)