Skip to content
This repository was archived by the owner on Mar 19, 2019. It is now read-only.

Upgrades ScalaTest assertions#302

Merged
johnsonr merged 1 commit into
masterfrom
test_assertions
Feb 9, 2017
Merged

Upgrades ScalaTest assertions#302
johnsonr merged 1 commit into
masterfrom
test_assertions

Conversation

@cdupuis

@cdupuis cdupuis commented Feb 9, 2017

Copy link
Copy Markdown
Contributor 
---
kind: "operation"
client: "rug-cli 0.23.0-SNAPSHOT"
executor:
  name: "UpgradeScalaTestAssertions"
  group: "atomist-rugs"
  artifact: "scala-editors"
  version: "0.1.0"
  origin:
    repo: "n/a"
    branch: "n/a"
    sha: "n/a"
@atomist-bot @cdupuis
Upgrades ScalaTest assertions
c1433a0 
```
---
kind: "operation"
client: "rug-cli 0.23.0-SNAPSHOT"
executor:
  name: "UpgradeScalaTestAssertions"
  group: "atomist-rugs"
  artifact: "scala-editors"
  version: "0.1.0"
  origin:
    repo: "n/a"
    branch: "n/a"
    sha: "n/a"

```
@CLAassistant

CLAassistant commented Feb 9, 2017 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.
@cdupuis cdupuis requested a review from johnsonr February 9, 2017 10:51
@cdupuis

cdupuis commented Feb 9, 2017

Copy link
Copy Markdown
Contributor Author

@johnsonr added you as reviewer to let you decide whether or not you want to merge this in.
@kipz

kipz commented Feb 9, 2017

Copy link
Copy Markdown
Contributor

Love it! +1
@johnsonr johnsonr merged commit 6012eff into master Feb 9, 2017
@johnsonr johnsonr deleted the test_assertions branch February 9, 2017 11:46
@claymccoy

claymccoy commented Feb 9, 2017

Copy link
Copy Markdown
Contributor

This is great.
One thought, DiagrammedAssertions given even better messages on failure and don't require the triple equals.
http://doc.scalatest.org/2.2.1/#org.scalatest.DiagrammedAssertions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

6 participants

@cdupuis @CLAassistant @kipz @claymccoy @johnsonr @atomist-bot