theme: Misc color scheme loading improvements

* Avoid calling initColorScheme() on navigation. It's not needed anymore after we moved the dark class to the document element.
* Move initColorScheme() to body end. Avoids blocking, seem to work as well preventing flickering on load.

Author: bep

assets/js/alpinejs/stores/nav.js

@@ -74,6 +74,10 @@ function isDark(colorScheme) {
 }
 
 export function initColorScheme() {
+	if (window.colorSchemeInitialized) {
+		return;
+	}
+	window.colorSchemeInitialized = true;
 	// The AlpineJS store has not have been initialized yet, so access the
 	// localStorage directly.
 	let settingsJSON = localStorage[localStorageUserSettingsKey];

assets/js/body-start.js renamed to assets/js/body-end.js

@@ -1,21 +1,13 @@
 import Alpine from 'alpinejs';
 import { registerMagics } from './alpinejs/magics/index';
 import { navbar, search, toc } from './alpinejs/data/index';
-import { navStore, initColorScheme } from './alpinejs/stores/index';
+import { navStore } from './alpinejs/stores/index';
 import { bridgeTurboAndAlpine } from './helpers/index';
 import persist from '@alpinejs/persist';
 import focus from '@alpinejs/focus';
 
 var debug = 0 ? console.log.bind(console, '[index]') : function () {};
 
-// Turbolinks init.
-(function () {
-	document.addEventListener('turbo:render', function (e) {
-		// This is also called right after the body start. This is added to prevent flicker on navigation.
-		initColorScheme();
-	});
-})();
-
 // Set up and start Alpine.
 (function () {
 	// Register AlpineJS plugins.

assets/js/main.js

@@ -1,3 +1,6 @@
+{{ with resources.Get "js/body-end.js" | js.Build (dict "minify" true) }}
+  {{ partial "helpers/linkjs.html" (dict "r" . "attributes" (dict "" "")) }}
+{{ end }}
 {{- if .IsHome }}
   {{- partial "helpers/validation/validate-keywords.html" }}
 {{- end }}

layouts/_partials/layouts/hooks/body-end.html

@@ -1,3 +0,0 @@
-{{ with resources.Get "js/body-start.js" | js.Build (dict "minify" true) }}
-  {{ partial "helpers/linkjs.html" (dict "r" . "attributes" (dict "" "")) }}
-{{ end }}