Enable CI test

Author: bep

.github/workflows/test.yml

@@ -37,4 +37,11 @@ jobs:
     - name: Lint
       run: golint ./...
     - name: Test
+      env:
+        S3RPC_CLIENT_QUEUE: https://sqs.eu-north-1.amazonaws.com/656975317043/s3fptest_client
+        S3RPC_SERVER_QUEUE: https://sqs.eu-north-1.amazonaws.com/656975317043/s3fptest_server
+        S3RPC_CLIENT_ACCESS_KEY_ID: AKIAZR5WHZAZ6KZKRKWG
+        S3RPC_CLIENT_SECRET_ACCESS_KEY: ${{ secrets.S3RPC_CLIENT_SECRET_ACCESS_KEY }}
+        S3RPC_SERVER_ACCESS_KEY_ID: AKIAZR5WHZAZT55IVJWN
+        S3RPC_SERVER_SECRET_ACCESS_KEY: ${{ secrets.S3RPC_SERVER_SECRET_ACCESS_KEY }}
       run: go test -race ./...

client.go

@@ -59,13 +59,15 @@ func NewClient(opts ClientOptions) (*Client, error) {
 
 }
 
+// Client is a client for executing operations on a server.
 type Client struct {
 	timeout time.Duration
 	*common
 }
 
 // ExecuteFilename executes the given op on a server with filename as its input.
 // This will block until the response is received or the timeout is reached.
+// Note that Output.Filename should be considered temporary and will be removed on Close.
 func (c *Client) ExecuteFilename(ctx context.Context, op, filename string) (Output, error) {
 	id := uuid.New().String()
 	key := fmt.Sprintf("%s/%s/%s_%s", toServer, op, id, filepath.Base(filename))
@@ -147,6 +149,7 @@ func (c *Client) ExecuteFilename(ctx context.Context, op, filename string) (Outp
 
 }
 
+// Close removes the temporary directory.
 func (c *Client) Close() error {
 	return os.RemoveAll(c.tempDir)
 }

common.go

@@ -45,10 +45,10 @@ type common struct {
 	infof func(format string, args ...interface{})
 }
 
-func (r *common) Receive(ctx context.Context) ([]message, error) {
-	result, err := r.sqsClient.ReceiveMessage(ctx,
+func (c *common) Receive(ctx context.Context) ([]message, error) {
+	result, err := c.sqsClient.ReceiveMessage(ctx,
 		&sqs.ReceiveMessageInput{
-			QueueUrl:            aws.String(r.queue),
+			QueueUrl:            aws.String(c.queue),
 			MaxNumberOfMessages: 5,
 			VisibilityTimeout:   visibilitySeconds,
 			// Wait for 20 seconds for a message to arrive.

roundtrip_test.go

@@ -14,10 +14,6 @@ import (
 )
 
 func TestProcessFile(t *testing.T) {
-	if os.Getenv("CI") != "" {
-		// TODO(bep)
-		t.Skip("skipping test in CI")
-	}
 	c := qt.New(t)
 
 	infofc := func(format string, args ...interface{}) {
@@ -85,18 +81,18 @@ func TestProcessFile(t *testing.T) {
 	c.Assert(err, qt.IsNil)
 	c.Assert(server, qt.Not(qt.IsNil))
 
-	ctx, cancel := context.WithTimeout(context.Background(), 120*time.Second)
-	defer cancel()
-
 	go func() {
-		if err := server.ListenAndServe(ctx); err != nil {
+		if err := server.ListenAndServe(); err != nil {
 			panic(err)
 		}
 	}()
 
 	wd, err := os.Getwd()
 	c.Assert(err, qt.IsNil)
 
+	ctx, cancel := context.WithTimeout(context.Background(), 120*time.Second)
+	defer cancel()
+
 	g, ctx := errgroup.WithContext(ctx)
 	g.Go(func() error {
 		res, err := client.ExecuteFilename(ctx, "dosomething", filepath.Join(wd, "go.mod"))
@@ -129,7 +125,7 @@ func TestSetup(t *testing.T) {
 		t.Skip("Skipping in CI")
 	}
 
-	prov, err := NewProvisioner("s3fptest", defaultRegion)
+	prov, err := NewProvisioner("s3fpdev", defaultRegion) // s3fptest is used on GitHub
 	if err != nil {
 		t.Fatal(err)
 	}

server.go

@@ -82,9 +82,9 @@ func (s *Server) Close() error {
 }
 
 // ListenAndServe listens for messages and processes them.
-// It blocks until the context is canceled or the server is closed.
-func (s *Server) ListenAndServe(ctx context.Context) error {
-	g, ctx := errgroup.WithContext(ctx)
+// It blocks until the server is closed.
+func (s *Server) ListenAndServe() error {
+	g, ctx := errgroup.WithContext(context.Background())
 	g.Go(func() error {
 		for {
 			select {