Skip to content

Commit 0c65063

Browse files
committed
Post-release bugfixes: Batch 2
This commit fixes the following bugs: - Viewing the Town Map in Viridian Pre-Gym would show the player as being in Cerulean. - Psychic, Psywave, Night Shade and Dazzling Gleam wouldn't shake the full screen - Okay, NOW it's impossible to trap yourself in Cinnabar Volcano. - Getting the Vermilion Beauty gift would lock you out from getting the Silph Co Lapras gift later. - Text fixes
1 parent 3e3b895 commit 0c65063

File tree

12 files changed

+37
-50
lines changed

12 files changed

+37
-50
lines changed

‎README.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,6 @@ and more!
262262

263263
Known Bugs
264264
====
265-
- Occasionally, saving and reloading in a building will cause the border tile to completely change, in some cases letting you walk out of bounds.
266265
- Trying to Surf from the overworld on Cycling Road has an invisible textbox stopping you, but just pressing A again lets you regain control.
267266
- Jumping from a specific tile off a ledge in Cerulean City causes you to land on a fence. This is being kept in, because it's funny.
268267

‎data/events/trades.asm‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ TradeMons:
2020
db SANDSLASH, SANDSLASH_A, TRADE_DIALOGSET_REGION, "SANDSLASH@@" ; Celadon
2121
db RAICHU, RAICHU_A, TRADE_DIALOGSET_REGION, "RAICHU@@@@@" ; Saffron
2222
db MAROWAK, MAROWAK_A, TRADE_DIALOGSET_REGION, "MAROWAK@@@@" ; Fuschia
23-
db MUK, MUK_A, TRADE_DIALOGSET_REGION, "MUK-A@@@@@@" ; Cinnabar
23+
db MUK, MUK_A, TRADE_DIALOGSET_REGION, "MUK@@@@@@@@" ; Cinnabar
2424
db EXEGGUTOR, EXEGGUTOR_A, TRADE_DIALOGSET_REGION, "EXEGGUTOR@@" ; Indigo
2525
db TAUROS, TAUROS_P, TRADE_DIALOGSET_TAUROSC, "TAUROS@@@@@" ; S.S. Anne begins here
2626
db TAUROS, TAUROS_PA, TRADE_DIALOGSET_TAUROSA, "TAUROS@@@@@"

‎data/maps/town_map_entries.asm‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ InternalMapEntries:
6767
internal_map MT_MOON_B2F, 6, 2, MountMoonName
6868
internal_map CERULEAN_MART, 10, 2, CeruleanCityName
6969
internal_map MT_MOON_POKECENTER, 5, 2, Route4Name
70-
internal_map VIRIDIAN_PRE_GYM, 10, 2, ViridianCityName
70+
internal_map VIRIDIAN_PRE_GYM, 2, 8, ViridianCityName
7171
internal_map DAYCARE, 10, 4, Route5Name
7272
internal_map UNDERGROUND_PATH_ROUTE_6, 10, 8, Route6Name
7373
internal_map CELESTE_HILL, 7, 9, CelesteHillName

‎engine/battle/animations.asm‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1861,8 +1861,8 @@ AnimationWavyScreen:
18611861
ld c, $ff
18621862
ld hl, WavyScreenLineOffsets
18631863
.loop
1864-
; ld a, [hl] ; this fixes the wavy screen, but causes a bank overflow
1865-
; ldh [hSCX], a
1864+
ld a, [hl] ; this fixes the wavy screen, but causes a bank overflow
1865+
ldh [hSCX], a
18661866
push hl
18671867
.innerLoop
18681868
call WavyScreen_SetSCX
@@ -1879,7 +1879,7 @@ AnimationWavyScreen:
18791879
dec c
18801880
jr nz, .loop
18811881
xor a
1882-
; ldh [hSCX], a ; also fixing the wavy screen
1882+
ldh [hSCX], a ; also fixing the wavy screen
18831883
ldh [hWY], a
18841884
call SaveScreenTilesToBuffer2
18851885
call ClearScreen

‎maps/CinnabarVolcano.blk‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
..............}vvvvvvvvvvvv}Qvvvvvvvvv}vvvvvvvvvvvvvvv45vvvvvvvv+67,vvvv8-%88vvNvvvvv vvvvR}vvvv vvv}N}vvv>vv}}}}Q}}}}}}QN
1+
..............}vvvvvvvvvvvv}Qvvvvvvvvv}vvvvvv3vvvvvvvvv45vvvvvvvv+67,vvvv8-%88vvNvvvvv vvvvR}vvvv vvv}N}vvv>vv}}}}Q}}}}}}QN

‎scripts/BattleTent.asm‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -820,13 +820,12 @@ BattleTentLetsGo:
820820
done
821821
822822
BattleTentWon:
823-
text "Wow! You finally"
824-
line "did it!"
823+
text "Congratulations!"
825824
826825
para "You beat"
827826
line "@"
828827
text_decimal wBTStreakCnt, 1, 3
829-
text " oppenont(s)!"
828+
text " opponent(s)!"
830829
prompt
831830
832831
BattleTentLost:

‎scripts/SilphCo7F.asm‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -309,8 +309,8 @@ SilphCo7TrainerHeader3:
309309
SilphCo7Text1:
310310
; lapras guy
311311
text_asm
312-
ld a, [wd72e]
313-
bit 0, a ; got lapras?
312+
ld a, [wd72c]
313+
bit 2, a
314314
jr z, .givelapras
315315
CheckEvent EVENT_BEAT_SILPH_CO_GIOVANNI
316316
jr nz, .savedsilph
@@ -329,8 +329,8 @@ SilphCo7Text1:
329329
call EnableAutoTextBoxDrawing
330330
ld hl, .HeresYourLaprasText
331331
call PrintText
332-
ld hl, wd72e
333-
set 0, [hl]
332+
ld hl, wd72c
333+
set 2, [hl]
334334
jr .done
335335
.savedsilph
336336
ld hl, .LaprasGuySavedText

‎text/CeruleanBadgeHouse.asm‎

Lines changed: 17 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@ _CeruleanHouse2Text_74e77::
33
line "are owned only by"
44
cont "skilled trainers."
55

6-
para "I see you have"
7-
line "at least one."
8-
96
para "Those BADGEs have"
107
line "amazing secrets!"
118
prompt
@@ -34,15 +31,9 @@ _CeruleanHouse2Text_74e96::
3431
prompt
3532

3633
_CeruleanHouse2Text_74e9b::
37-
text "#MON up to L30"
38-
line "will obey you."
39-
40-
para "Any higher, they"
41-
line "become unruly!"
42-
43-
para "It also lets you"
44-
line "use CUT outside"
45-
cont "of battle."
34+
text "It lets you use"
35+
line "CUT outside of"
36+
cont "battle."
4637
prompt
4738

4839
_CeruleanHouse2Text_74ea0::
@@ -56,15 +47,9 @@ _CeruleanHouse2Text_74ea0::
5647
prompt
5748

5849
_CeruleanHouse2Text_74ea5::
59-
text "#MON up to L50"
60-
line "will obey you."
61-
62-
para "Any higher, they"
63-
line "become unruly!"
64-
65-
para "It also lets you"
66-
line "use STRENGTH out-"
67-
cont "side of battle."
50+
text "It lets you use"
51+
line "STRENGTH outside"
52+
cont "of battle."
6853
prompt
6954

7055
_CeruleanHouse2Text_74eaa::
@@ -78,11 +63,14 @@ _CeruleanHouse2Text_74eaa::
7863
prompt
7964

8065
_CeruleanHouse2Text_74eaf::
81-
text "#MON up to L70"
82-
line "will obey you."
83-
84-
para "Any higher, they"
85-
line "become unruly!"
66+
text "Hmm... I can't"
67+
line "remember."
68+
69+
para "Should you beat"
70+
line "SABRINA's tough"
71+
cont "PSYCHIC #MON,"
72+
cont "she may tell"
73+
cont "you."
8674
prompt
8775

8876
_CeruleanHouse2Text_74eb4::
@@ -92,6 +80,7 @@ _CeruleanHouse2Text_74eb4::
9280
prompt
9381

9482
_CeruleanHouse2Text_74eb9::
95-
text "All #MON will"
96-
line "obey you!"
83+
text "You'll be able to"
84+
line "challenge the"
85+
cont "#MON LEAGUE!"
9786
prompt

‎text/CitrineCity.asm‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ _CitrineCityCavern::
3838

3939
_CitrineCityDirections::
4040
text "NORTH WEST:"
41-
line "BATTLE TOWER"
41+
line "BATTLE TENT"
4242
4343
para "NORTH EAST:"
4444
line "CELESTE HILL"

‎text/Daycare_2.asm‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ _DayCareAllRightThenText::
44
text_end
55

66
_DayCareComeAgainText::
7-
text "come again."
7+
text "Come again."
88
done
99

1010
_DayCareNoRoomForMonText::

0 commit comments

Comments
 (0)