Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bmatcuk/doublestar
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.9.1
Choose a base ref
...
head repository: bmatcuk/doublestar
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.9.2
Choose a head ref
  • 5 commits
  • 5 files changed
  • 2 contributors

Commits on Jul 26, 2025

  1. notes about globbing

    bmatcuk committed Jul 26, 2025
    Configuration menu
    Copy the full SHA
    9fded31 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2026

  1. test: add failing tests for brace expansion with meta char directories

    Add test cases that demonstrate the bug where brace expansion fails to match paths containing literal meta characters in directory names.
    
    The following patterns fail to match correctly:
    - e/**/{z,other} with e/[x]/[y]/z: brackets interpreted as character class
    - f/\{a,b\}/{c,other} with f/{a,b}/c: braces interpreted as brace expansion
    - f/\*/{a,other} with f/*/a: asterisk interpreted as wildcard (over-matches)
    - f/\?/{a,other} with f/?/a: question mark interpreted as wildcard (over-matches)
    
    These tests will pass once the fix for escaping meta characters in globAlts/buildAlt is implemented.
    toga4 committed Jan 7, 2026
    Configuration menu
    Copy the full SHA
    b191bb9 View commit details
    Browse the repository at this point in the history
  2. fix: escape meta characters in paths during brace expansion

    When processing brace expansion (e.g., `{a,b}`), the globAlts and doGlobAltsWalk functions build new patterns by combining filesystem paths with pattern fragments.
    Previously, paths containing meta characters (e.g., `[orderID]`, `{a,b}`, `*`, `?`) were passed directly to buildAlt without escaping, causing them to be interpreted as glob patterns rather than literal path components.
    
    This fix adds an escapeMeta function (the inverse of unescapeMeta) and applies it to filesystem-derived paths before building alternative patterns.
    
    This ensures that:
    
    - `[...]` in paths are not interpreted as character classes
    - `{...}` in paths are not interpreted as brace expansions
    - `*` and `?` in paths are not interpreted as wildcards
    
    Also renamed metaReplacer to unescapeMetaReplacer for clarity.
    toga4 committed Jan 7, 2026
    Configuration menu
    Copy the full SHA
    4ef2b00 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2026

  1. fix tests

    bmatcuk committed Jan 10, 2026
    Configuration menu
    Copy the full SHA
    4db19e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3dc8306 View commit details
    Browse the repository at this point in the history
Loading