Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 2 commits
- 7 files changed
- 2 contributors
Commits on Jul 1, 2025
-
sql: ignore some session variables in RESET ALL
Looking at `src/backend/utils/misc/guc_tables.c` in PG source code, there are a few session variables flagged with `GUC_NO_RESET_ALL` that should not be affected by RESET ALL. This commit adds a `NoResetAll` flag to the following session variables that overlap with PG: - `is_superuser` - `role` - `session_authorization` - `transaction_isolation` - `transaction_read_only` This commit also adds the flag to a couple CRDB-only session variables that seem similar: - `transaction_priority` - `transaction_status` Most of these variables are read-only, and so were not affected by RESET ALL, but the new flag makes the intended behavior clear in case any of them do become writable in the future. By fixing RESET ALL, this change also makes DISCARD ALL work correctly when `default_transaction_use_follower_reads` is enabled. Fixes: #124150 Release note (bug fix): The RESET ALL statement is fixed to no longer affect the following session variables: - `is_superuser` - `role` - `session_authorization` - `transaction_isolation` - `transaction_priority` - `transaction_status` - `transaction_read_only` This better matches PostgreSQL behavior for RESET ALL. By fixing RESET ALL, the DISCARD ALL statement is also fixed to work correctly when `default_transaction_use_follower_reads` is enabled.
Commits on Jul 2, 2025
-
148770: sql: ignore some session variables in RESET ALL r=rafiss,yuzefovich a=michae2 Looking at `src/backend/utils/misc/guc_tables.c` in PG source code, there are a few session variables flagged with `GUC_NO_RESET_ALL` that should not be affected by RESET ALL. This commit adds a `NoResetAll` flag to the following session variables that overlap with PG: - `is_superuser` - `role` - `session_authorization` - `transaction_isolation` - `transaction_read_only` This commit also adds the flag to a couple CRDB-only session variables that seem similar: - `transaction_priority` - `transaction_status` Most of these variables are read-only, and so were not affected by RESET ALL, but the new flag makes the intended behavior clear in case any of them do become writable in the future. By fixing RESET ALL, this change also makes DISCARD ALL work correctly when `default_transaction_use_follower_reads` is enabled. Fixes: #124150 Release note (bug fix): The RESET ALL statement is fixed to no longer affect the following session variables: - `is_superuser` - `role` - `session_authorization` - `transaction_isolation` - `transaction_priority` - `transaction_status` - `transaction_read_only` This better matches PostgreSQL behavior for RESET ALL. By fixing RESET ALL, the DISCARD ALL statement is also fixed to work correctly when `default_transaction_use_follower_reads` is enabled. Co-authored-by: Michael Erickson <michae2@cockroachlabs.com>
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...staging