Merge pull request #71 from csprance/codex/review-and-optimize-ecs-for-speed

Remove unused QueryBuilder pooling

Author: csprance

CHANGELOG.md

@@ -1,5 +1,10 @@
 # GECS Changelog
 
+## [Unreleased]
+
+### Removed
+- Removed the unused QueryBuilder pooling infrastructure; `World.query` now always creates a fresh builder while retaining cache invalidation wiring for clarity and predictable lifecycle management.
+
 ## [5.0.0] - 2025-10-15 - Major ECS Overhaul & Performance Awesomeness (Some Small Breaking Changes)
 
 **GECS v5.0.0 is a major release with massive performance improvements, API simplification, and relationship system overhaul.**

addons/gecs/ecs/world.gd

@@ -72,14 +72,9 @@ var entity_to_archetype: Dictionary = {} # Entity -> Archetype
 ## so that all queries are invalidated anytime we emit cache_invalidated.
 var query: QueryBuilder:
 	get:
-		var q: QueryBuilder
-		if _query_builder_pool.is_empty():
-			q = QueryBuilder.new(self )
-			if not cache_invalidated.is_connected(q.invalidate_cache):
-				cache_invalidated.connect(q.invalidate_cache)
-		else:
-			q = _query_builder_pool.pop_back()
-			q.clear()
+		var q: QueryBuilder = QueryBuilder.new(self)
+		if not cache_invalidated.is_connected(q.invalidate_cache):
+			cache_invalidated.connect(q.invalidate_cache)
 		return q
 ## Index for relationships to entities (Optional for optimization)
 var relationship_entity_index: Dictionary = {}
@@ -90,9 +85,6 @@ var _worldLogger = GECSLogger.new().domain("World")
 ## Cache for commonly used query results - stores matching archetypes, not entities
 ## This dramatically reduces cache invalidation since archetypes are stable
 var _query_archetype_cache: Dictionary = {} # query_sig -> Array[Archetype]
-## Pool of QueryBuilder instances to reduce creation overhead
-var _query_builder_pool: Array[QueryBuilder] = []
-var _pool_size_limit: int = 10
 ## Track cache hits for performance monitoring
 var _cache_hits: int = 0
 var _cache_misses: int = 0
@@ -1058,13 +1050,6 @@ func _invalidate_cache(reason: String) -> void:
 		_cache_invalidation_reasons[reason] = _cache_invalidation_reasons.get(reason, 0) + 1
 
 
-## Return a QueryBuilder instance to the pool for reuse
-func _return_query_builder_to_pool(query_builder: QueryBuilder) -> void:
-	if _query_builder_pool.size() < _pool_size_limit:
-		query_builder.clear()
-		_query_builder_pool.append(query_builder)
-
-
 ## Calculate archetype signature for an entity based on its components
 ## Uses the same hash function as queries for consistency
 ## An entity signature is just a query with all its components (no any/exclude)