more linting

Author: nkvuong

src/test/java/io/delta/sharing/java/DeltaSharingTestCase.java

@@ -1,33 +1,33 @@
 package io.delta.sharing.java;
 
+
 import io.delta.sharing.java.adaptor.DeltaSharingJsonProvider;
 import io.delta.sharing.java.mocks.Mocks;
 import io.delta.sharing.spark.DeltaSharingProfileProvider;
 import io.delta.sharing.spark.model.Table;
-import org.junit.jupiter.api.Assertions;
-import org.junit.jupiter.api.Test;
-
 import java.io.IOException;
 import java.net.URISyntaxException;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.util.LinkedList;
 import java.util.List;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
 
+/**
+ * Test cases for Delta Sharing connector.
+ *
+ */
 public class DeltaSharingTestCase {
 
   @Test
   public void testGetters() throws IOException {
     DeltaSharingProfileProvider profileProvider = new DeltaSharingJsonProvider(Mocks.providerJson);
     Path checkpointPath = Paths.get("target/testing/");
     DeltaSharing sharing = DeltaSharingFactory.create(profileProvider, checkpointPath);
-    Assertions.assertAll(
-        "assert sharing client",
-        () ->
-            Assertions.assertNotNull(sharing.getHttpClient()),
-        () ->
-            Assertions.assertNotNull(sharing.getProfileProvider())
-    );
+    Assertions.assertAll("assert sharing client",
+        () -> Assertions.assertNotNull(sharing.getHttpClient()),
+        () -> Assertions.assertNotNull(sharing.getProfileProvider()));
   }
 
   @Test

src/test/java/io/delta/sharing/java/adaptor/DeltaSharingJSONProviderTestCase.java

@@ -8,6 +8,12 @@
 import org.junit.jupiter.api.Test;
 
 
+/** 
+ * Test cases for Delta Sharing Json Provider.
+ *
+ * @throws JsonProcessingException for all problems encountered when processing Json
+ */
+
 public class DeltaSharingJsonProviderTestCase {
 
   @SuppressWarnings("ResultOfMethodCallIgnored")

src/test/java/io/delta/sharing/java/format/parquet/LocalInputFileTestCase.java

@@ -1,98 +1,87 @@
 package io.delta.sharing.java.format.parquet;
 
-import org.apache.parquet.io.SeekableInputStream;
-import org.junit.jupiter.api.Assertions;
-import org.junit.jupiter.api.Test;
-
 import java.io.IOException;
 import java.nio.ByteBuffer;
 import java.nio.file.Path;
 import java.nio.file.Paths;
+import org.apache.parquet.io.SeekableInputStream;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
 
+/** 
+ * Test cases for local Input File.
+ *
+ * @throws IOException for all IO problems
+ */
 public class LocalInputFileTestCase {
 
   @Test
   public void testRead() throws IOException {
-    Path filePath = Paths.get("src", "test", "resources", "table_reader_test_data.parquet").toAbsolutePath();
+    Path filePath =
+        Paths.get("src", "test", "resources", "table_reader_test_data.parquet").toAbsolutePath();
     LocalInputFile localInputFile = new LocalInputFile(filePath);
 
     byte[] b = new byte[1024];
     SeekableInputStream stream = localInputFile.newStream();
 
-    Assertions.assertDoesNotThrow(
-        () -> stream.read(b),
-        "assert no exception for read with buffer"
-    );
-
-    Assertions.assertDoesNotThrow(
-        () -> stream.read(),
-        "assert no exception for read without buffer"
-    );
-
-    Assertions.assertDoesNotThrow(
-        () -> stream.read(b, 100, 100),
-        "assert no exception for read with offset using a buffer"
-    );
-
-    Assertions.assertDoesNotThrow(
-        () -> stream.readFully(b, 100, 100),
-        "assert no exception for read with offset using a buffer"
-    );
+    Assertions.assertDoesNotThrow(() -> stream.read(b), "assert no exception for read with buffer");
+
+    Assertions.assertDoesNotThrow(() -> stream.read(),
+        "assert no exception for read without buffer");
+
+    Assertions.assertDoesNotThrow(() -> stream.read(b, 100, 100),
+        "assert no exception for read with offset using a buffer");
+
+    Assertions.assertDoesNotThrow(() -> stream.readFully(b, 100, 100),
+        "assert no exception for read with offset using a buffer");
   }
 
   @Test
   public void testSkip() throws IOException {
-    Path filePath = Paths.get("src", "test", "resources", "table_reader_test_data.parquet").toAbsolutePath();
+    Path filePath =
+        Paths.get("src", "test", "resources", "table_reader_test_data.parquet").toAbsolutePath();
     LocalInputFile localInputFile = new LocalInputFile(filePath);
 
     byte[] b = new byte[1024];
     SeekableInputStream stream = localInputFile.newStream();
 
-    Assertions.assertDoesNotThrow(
-        () -> stream.skip(100) + stream.read(b),
-        "assert no exception for read after a skip"
-    );
+    Assertions.assertDoesNotThrow(() -> stream.skip(100) + stream.read(b),
+        "assert no exception for read after a skip");
   }
 
   @Test
   public void testReadByteBuffers() throws IOException {
-    Path filePath = Paths.get("src", "test", "resources", "table_reader_test_data.parquet").toAbsolutePath();
+    Path filePath =
+        Paths.get("src", "test", "resources", "table_reader_test_data.parquet").toAbsolutePath();
     LocalInputFile localInputFile = new LocalInputFile(filePath);
 
-    //8192 is page size constant inside the LocalInputFile
+    // 8192 is page size constant inside the LocalInputFile
     ByteBuffer byteBuffer = ByteBuffer.allocateDirect(8192 * 4);
     SeekableInputStream stream = localInputFile.newStream();
 
-    Assertions.assertDoesNotThrow(
-        () -> stream.read(byteBuffer),
-        "assert no exception for read with byte buffer"
-    );
+    Assertions.assertDoesNotThrow(() -> stream.read(byteBuffer),
+        "assert no exception for read with byte buffer");
 
-    Assertions.assertDoesNotThrow(
-        () -> stream.readFully(byteBuffer),
-        "assert no exception for readFully with byte buffer"
-    );
+    Assertions.assertDoesNotThrow(() -> stream.readFully(byteBuffer),
+        "assert no exception for readFully with byte buffer");
   }
 
   @Test
   public void testPointers() throws IOException {
-    Path filePath = Paths.get("src", "test", "resources", "table_reader_test_data.parquet").toAbsolutePath();
+    Path filePath =
+        Paths.get("src", "test", "resources", "table_reader_test_data.parquet").toAbsolutePath();
     LocalInputFile localInputFile = new LocalInputFile(filePath);
 
-    //8192 is page size constant inside the LocalInputFile
+    // 8192 is page size constant inside the LocalInputFile
     SeekableInputStream stream = localInputFile.newStream();
 
     Assertions.assertTrue(stream.markSupported());
     Assertions.assertEquals(stream.available(), 0);
 
-    Assertions.assertDoesNotThrow(
-        () -> stream.mark(0),
-        "assert mark operation doesnt throw an exception"
-    );
+    Assertions.assertDoesNotThrow(() -> stream.mark(0),
+        "assert mark operation doesnt throw an exception");
 
-    Assertions.assertDoesNotThrow(
-        () -> stream.mark(0),
-        "assert mark operation doesnt throw an exception"
-    );
+    Assertions.assertDoesNotThrow(() -> stream.mark(0),
+        "assert mark operation doesnt throw an exception");
   }
 }

src/test/java/io/delta/sharing/java/format/parquet/TableReaderTestCase.java

@@ -1,57 +1,51 @@
 package io.delta.sharing.java.format.parquet;
 
-import org.apache.avro.Schema;
-import org.apache.avro.generic.GenericRecord;
-import org.junit.jupiter.api.Assertions;
-import org.junit.jupiter.api.Test;
-
 import java.io.IOException;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.util.LinkedList;
 import java.util.List;
+import org.apache.avro.Schema;
+import org.apache.avro.generic.GenericRecord;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
 
+/**
+ * Test cases for Table Reader.
+ *
+ * @throws IOException for all IO problems
+ */
 public class TableReaderTestCase {
 
   @Test
   public void testRead() throws IOException {
     List<Path> paths = new LinkedList<>();
     paths.add(
-      Paths.get("src", "test", "resources", "table_reader_test_data.parquet").toAbsolutePath()
-    );
+        Paths.get("src", "test", "resources", "table_reader_test_data.parquet").toAbsolutePath());
 
     TableReader<GenericRecord> tableReader = new TableReader<>(paths);
 
     GenericRecord record = tableReader.read();
     Schema schema = record.getSchema();
     Schema.Field field = schema.getFields().get(0);
-    Assertions.assertAll(
-      "assert table reader",
-      () ->
-        Assertions.assertEquals(record.get("date").toString(), "2020-10-10"),
-      () ->
-        Assertions.assertEquals(record.get(field.name()).toString(), "2020-10-10")
-    );
+    Assertions.assertAll("assert table reader",
+        () -> Assertions.assertEquals(record.get("date").toString(), "2020-10-10"),
+        () -> Assertions.assertEquals(record.get(field.name()).toString(), "2020-10-10"));
   }
 
   @Test
   public void testReadN() throws IOException {
     List<Path> paths = new LinkedList<>();
     paths.add(
-        Paths.get("src", "test", "resources", "table_reader_test_data.parquet").toAbsolutePath()
-    );
+        Paths.get("src", "test", "resources", "table_reader_test_data.parquet").toAbsolutePath());
 
     TableReader<GenericRecord> tableReader = new TableReader<>(paths);
 
     List<GenericRecord> records = tableReader.readN(2);
     Schema schema = records.get(0).getSchema();
     Schema.Field field = schema.getFields().get(0);
-    Assertions.assertAll(
-        "assert table reader",
-        () ->
-            Assertions.assertEquals(records.get(0).get("date").toString(), "2020-10-10"),
-        () ->
-            Assertions.assertEquals(records.get(0).get(field.name()).toString(), "2020-10-10")
-    );
+    Assertions.assertAll("assert table reader",
+        () -> Assertions.assertEquals(records.get(0).get("date").toString(), "2020-10-10"),
+        () -> Assertions.assertEquals(records.get(0).get(field.name()).toString(), "2020-10-10"));
   }
 }

src/test/java/io/delta/sharing/java/mocks/Mocks.java

@@ -1,25 +1,21 @@
 package io.delta.sharing.java.mocks;
 
+/** 
+ * Mock for provider json.
+ */
 public class Mocks {
-  public static String providerJson = "{\n" +
-      "  \"shareCredentialsVersion\": 1,\n" +
-      "  \"endpoint\": \"https://sharing.delta.io/delta-sharing/\",\n" +
-      "  \"bearerToken\": \"faaie590d541265bcab1f2de9813274bf233\"\n" +
-      "}";
+  public static String providerJson = "{\n" + "  \"shareCredentialsVersion\": 1,\n"
+      + "  \"endpoint\": \"https://sharing.delta.io/delta-sharing/\",\n"
+      + "  \"bearerToken\": \"faaie590d541265bcab1f2de9813274bf233\"\n" + "}";
 
-  public static String ProviderJsonUnsupportedCredentials = "{\n" +
-      "  \"shareCredentialsVersion\": 12,\n" +
-      "  \"endpoint\": \"https://sharing.delta.io/delta-sharing/\",\n" +
-      "  \"bearerToken\": \"faaie590d541265bcab1f2de9813274bf233\"\n" +
-      "}";
+  public static String ProviderJsonUnsupportedCredentials =
+      "{\n" + "  \"shareCredentialsVersion\": 12,\n"
+          + "  \"endpoint\": \"https://sharing.delta.io/delta-sharing/\",\n"
+          + "  \"bearerToken\": \"faaie590d541265bcab1f2de9813274bf233\"\n" + "}";
 
-  public static String ProviderJsonNoEndpoint = "{\n" +
-      "  \"shareCredentialsVersion\": 12,\n" +
-      "  \"bearerToken\": \"faaie590d541265bcab1f2de9813274bf233\"\n" +
-      "}";
+  public static String ProviderJsonNoEndpoint = "{\n" + "  \"shareCredentialsVersion\": 12,\n"
+      + "  \"bearerToken\": \"faaie590d541265bcab1f2de9813274bf233\"\n" + "}";
 
-  public static String ProviderJsonNoToken = "{\n" +
-      "  \"shareCredentialsVersion\": 1,\n" +
-      "  \"endpoint\": \"https://sharing.delta.io/delta-sharing/\",\n" +
-      "}";
+  public static String ProviderJsonNoToken = "{\n" + "  \"shareCredentialsVersion\": 1,\n"
+      + "  \"endpoint\": \"https://sharing.delta.io/delta-sharing/\",\n" + "}";
 }