Skip to content

fix(types): return this rather than the class - #360

Merged
WilcoFiers merged 1 commit into
developfrom
return-this
Sep 9, 2021
Merged

fix(types): return this rather than the class#360
WilcoFiers merged 1 commit into
developfrom
return-this

Conversation

@WilcoFiers

@WilcoFiers WilcoFiers commented Sep 9, 2021

Copy link
Copy Markdown
Contributor

These need to return this, so that the classes can properly be extended. If we didn't return this, the following would be a problem:

class DevToolsWebdriverIO extends AxeBuilder {
  foo() {}
}
// foo does not exist on type AxeBuilder
new DevToolsWebdriverIO().include('foo').foo();
@WilcoFiers
WilcoFiers merged commit 7999891 into develop Sep 9, 2021
@WilcoFiers
WilcoFiers deleted the return-this branch September 9, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@WilcoFiers @Zidious