feat(cli): better error message for ChromeDriver version mismatch - #680
Conversation
|
|
straker
left a comment
straker
left a comment
There was a problem hiding this comment.
Thanks for the pr! This type of message will help a ton.
|
Hey @not-my-profile just reaching out to see if you've seen the request changes on the PR. |
63c7d4e to
d54a370
Compare
d54a370 to
aefecb3
Compare
| $ npm install -g chromedriver@<version> | ||
| $ axe --chromedriver-path $(npm root -g)/chromedriver/bin/chromedriver <url...> | ||
|
|
||
| (where <version> is the first number of the "current browser version" reported above.)`); |
There was a problem hiding this comment.
"the first number" is a bit ambiguous. We should be very specific about what we want as browser version 114.0.5735.198 the first number would be 1 which would not be the version of chromedriver we want.
There was a problem hiding this comment.
You're confusing "digit" with "number". I changed your suggestion of "major version" to "first number of the version" since I think there's a good chance that the user isn't familiar with SemVer.
|
Hey @not-my-profile ! Just missing a test and I think this is good to go |
|
Thanks for the contribution. Reviewed for security |
5 participants
Fixes #679.