fix: allow cjs version of packages to export a default value - #943
Merged
Conversation
WilcoFiers
reviewed
Nov 27, 2023
Comment on lines
+4
to
+9
| * "Fixes" the esbuild problem of exporting the CJS default export as `module.exports.default` | ||
| * instead of `module.exports`. The plugin appends a block of code to the file that takes the | ||
| * `.default` module export and re-exports it as `module.exports`. It then takes all named | ||
| * exports and re-exports them as part of the `module.exports` under the same name. This also | ||
| * gives the benefit of exporting the `.default` module which allows us to support all 3 export | ||
| * styles: the default export, `.default` export, and named exports. |
Contributor
There was a problem hiding this comment.
Is there an issue with ESBuild open on this? If not, could you submit one? This feels like it would be a generally useful feature.
WilcoFiers
previously approved these changes
Nov 27, 2023
WilcoFiers
left a comment
WilcoFiers
left a comment
Contributor
There was a problem hiding this comment.
Small nitpick, up to you.
WilcoFiers
approved these changes
Nov 30, 2023
Merged
Merged
Merged
Closed
This was referenced Jul 16, 2024
This was referenced Sep 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an esbuild plugin to "fix" the esbuild problem of having
export default achanged intomodule.exports.default = ainstead ofmodules.exports = a. Using the plugin removes the build warnings we get from esbuild when we tried to addmodule.exportsinto the code to do this manually.Closes #948