cli/command/service: preserve mount order on service update - #7262
Closed
FrancescoCastaldi wants to merge 1 commit into
Closed
cli/command/service: preserve mount order on service update#7262FrancescoCastaldi wants to merge 1 commit into
FrancescoCastaldi wants to merge 1 commit into
Conversation
Only call updateMounts when --mount-add or --mount-rm flags were explicitly provided. This prevents unconditional reordering of mounts during service updates (e.g. docker service update --force), avoiding unnecessary rollouts on subsequent docker stack deploy. Fixes docker#7226
Member
|
duplicate of #7227 While this addresses part of the issue, I think there's another issue; the mount should not be depending on order in the compose file, and be sorted by target (mount-point) instead of source. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed
docker service update(such as with--force) so it preserves existing service mount order when no mount flags are supplied.This prevents a subsequent identical
docker stack deployfrom detecting a mount-order difference and unnecessarily rolling the service again.Fixes #7226
- How I did it
Updated
updateService()incli/command/service/update.goto callupdateMounts()only when--mount-addor--mount-rmwas explicitly changed (anyChanged(flags, flagMountAdd, flagMountRemove)), matching the pattern used for all other properties inupdateService.Added regression test
TestUpdateServiceForcePreservesMountOrderincli/command/service/update_test.go.- How to verify it