Skip to content
This repository was archived by the owner on Nov 21, 2025. It is now read-only.

fix(dev-env/basic): building and running development#1646

Merged
renatobenks merged 2 commits into
mainfrom
fix/dev-env-build
Aug 2, 2021
Merged

fix(dev-env/basic): building and running development#1646
renatobenks merged 2 commits into
mainfrom
fix/dev-env-build

Conversation

@renatobenks

@renatobenks renatobenks commented Jul 26, 2021

Copy link
Copy Markdown
Contributor

Description

The development environment, aka dev-env/basic, is not properly working, currently because of a build problem.

Review

  • Changes on script dev in dev-env/basic
  • Lock of dependencies on yarn, just to make sure that I'm not upgrading anything that I shouldn't

Pre-merge checklist

  • Check dev script on dev-env/basic which should be working now

Screenshots

Before After
image Screen Shot 2021-07-29 at 18 10 17
@renatobenks renatobenks changed the base branch from dev to main July 29, 2021 21:35
"dependencies": {
"cpx": "^1.5.0",
"docz": "next",
"docz": "../../core/docz",

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@pedronauck pedronauck left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happened here when I tried to run yarn dev inside dev-env/basic and check localhost:3000

Screen Shot 2021-07-29 at 19 00 48

@renatobenks

renatobenks commented Jul 30, 2021

Copy link
Copy Markdown
Contributor Author

I'm checking it! Thank you for testing.

@renatobenks

Copy link
Copy Markdown
Contributor Author

@pedronauck I just checked everything around by setting this up from scratch and it seems to be working fine now. Can you try it again, but this time from a clean setup?

Let me know how it works then.

@renatobenks renatobenks merged commit 7baaaf2 into main Aug 2, 2021
@renatobenks renatobenks deleted the fix/dev-env-build branch August 2, 2021 20:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants