Exclude glassfish Executor which does not permit wrapped runnables#596
Merged
felixbarny merged 5 commits intoelastic:masterfrom Apr 23, 2019
Merged
Exclude glassfish Executor which does not permit wrapped runnables#596felixbarny merged 5 commits intoelastic:masterfrom
felixbarny merged 5 commits intoelastic:masterfrom
Conversation
Member
Author
|
Contains no tests because we would have to instrument |
Member
Author
|
Snapshot for this PR: elastic-apm-agent-1.6.1-SNAPSHOT.jar.zip |
Member
Author
|
@mdindoffer could you give this snapshot a try? |
Contributor
|
@felixbarny Perfect, that seems to do the trick. |
eyalkoren
reviewed
Apr 22, 2019
...concurrent-plugin/src/main/java/co/elastic/apm/agent/concurrent/ExecutorInstrumentation.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #596 +/- ##
============================================
+ Coverage 62.4% 62.42% +0.02%
Complexity 68 68
============================================
Files 188 188
Lines 7062 7066 +4
Branches 814 814
============================================
+ Hits 4407 4411 +4
Misses 2387 2387
Partials 268 268
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #589