Don't throw exception if instrumented function is missing#142
Merged
intuibase merged 1 commit intoelastic:mainfrom Jan 2, 2025
Merged
Don't throw exception if instrumented function is missing#142intuibase merged 1 commit intoelastic:mainfrom
intuibase merged 1 commit intoelastic:mainfrom
Conversation
intuibase
force-pushed
the
dont_throw_if_func_is_missing
branch
from
79b382d to
a61d941
Compare
SergeyKleyman
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During MySQLi instrumentation development, I realized that there might be functions introduced or deprecated depending on the PHP version. In such cases, we don’t want to throw any exceptions but instead log it at the debug level.