Deprecate client.type#104574
Merged
elasticsearchmachine merged 5 commits intoelastic:mainfrom Feb 6, 2024
Merged
Conversation
client.type existed from the days of the node client existing alongside the java client. Since the node client no longer exists, it no longer serves a purpose, and is already ignored. Yet the setting still exists. This commit deprecates the client.type node setting.
rjernst
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
|
Hi @rjernst, I've created a changelog YAML for you. Note that since this PR is labelled |
rjernst
added
the
auto-merge-without-approval
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Dec 6, 2024
The client.type setting is a holdover from the node client which was removed in 8.0. The setting has been a noop since 8.0. This commit removes the setting. relates elastic#104574
rjernst
added a commit
that referenced
this pull request
Dec 9, 2024
The client.type setting is a holdover from the node client which was removed in 8.0. The setting has been a noop since 8.0. This commit removes the setting. relates #104574
Contributor
|
@rjernst is this PR relevant to the serverless changelog? [FYI this question is based on 9.0 breaking changes] |
Member
Author
|
No, this does not affect serverless at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client.type existed from the days of the node client existing alongside the java client. Since the node client no longer exists, it no longer serves a purpose, and is already ignored. Yet the setting still exists. This commit deprecates the client.type node setting.