Skip to content

Add correct mapping for event.created - #3579

Merged
leehinman merged 1 commit into
elastic:mainfrom
leehinman:event_created_fix
Jun 24, 2022
Merged

Add correct mapping for event.created#3579
leehinman merged 1 commit into
elastic:mainfrom
leehinman:event_created_fix

Conversation

@leehinman

@leehinman leehinman commented Jun 24, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

data_streams that could use httpjson as an input need a field mapping for event.created because httpjson creates that field.

  • apache: error
  • atlassian_bitbucket: audit
  • carbon_black_cloud: alert, asset_vulnerability_summary, audit,
    endpoint_event, watchlist_hit
  • github: audit
  • httpjson: generic
  • snyk: audit, vulnerabilities
  • winlog: winlog

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
    - [ ] I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] I have verified that Kibana version constraints are current according to guidelines.

Related issues

data_streams that could use httpjson as an input need a field mapping
for event.created because httpjson creates that field.

- apache: error
- atlassian_bitbucket: audit
- carbon_black_cloud: alert, asset_vulnerability_summary, audit,
  endpoint_event, watchlist_hit
- github: audit
- httpjson: generic
- snyk: audit, vulnerabilities
- winlog: winlog

Closes elastic#3577
@leehinman
leehinman force-pushed the event_created_fix branch from a5d1808 to 3921797 Compare June 24, 2022 00:58
@leehinman leehinman added bug Something isn't working, use only for issues Team:Security-External Integrations labels Jun 24, 2022
@leehinman
leehinman marked this pull request as ready for review June 24, 2022 01:00
@leehinman
leehinman requested review from a team as code owners June 24, 2022 01:00
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

elasticmachine commented Jun 24, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-24T00:58:57.338+0000

  • Duration: 17 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 188
Skipped 0
Total 188

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (11/11) 💚
Files 84.615% (11/13) 👎 -11.92
Classes 84.615% (11/13) 👎 -11.92
Methods 90.196% (138/153) 👍 1.341
Lines 91.893% (2063/2245) 👍 0.941
Conditionals 100.0% (0/0) 💚

@muthu-mps muthu-mps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When looking into the httpjson field mapping the following fields appears in the sample_events and missing in the mapping [event.ingested, event.agent_id_status, message]. We may need to take this as a separate issue.

@muthu-mps
muthu-mps self-requested a review June 24, 2022 15:21

@muthu-mps muthu-mps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise Looks good!

@leehinman
leehinman merged commit 025c113 into elastic:main Jun 24, 2022
@leehinman
leehinman deleted the event_created_fix branch June 24, 2022 15:49
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
data_streams that could use httpjson as an input need a field mapping
for event.created because httpjson creates that field.

- apache: error
- atlassian_bitbucket: audit
- carbon_black_cloud: alert, asset_vulnerability_summary, audit,
  endpoint_event, watchlist_hit
- github: audit
- httpjson: generic
- snyk: audit, vulnerabilities
- winlog: winlog

Closes elastic#3577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues

4 participants