Skip to content

Commit ecd98ef

Browse files
authored
[Infrastructure UI] Upgrade assistand: Extend deprecation errors rules for 8.x (#153094)
Closes #152954 ## Summary This PR fixes the issue with deprecation errors in the Upgrade assistance for versions newer than 8.x ### Testing 1. First check that they are no error - go to Kibana > Stack Management > Upgrade assistant and there shouldn't be any critical errors: ![image](https://user-images.githubusercontent.com/14139027/224307316-70b800c6-ec8e-442e-8b93-5b53886b13e8.png) 2. Go to Kibana > Infrastructure > Settings and change the default value from `metrics-*,metricbeat-*` to anything else - even `metricbeat-*,metrics-*` (swapping the order) will work. Apply the changes. <img width="1725" alt="image" src="https://user-images.githubusercontent.com/14139027/224307871-bd710809-c1da-4403-8b48-1e0f9ad8298b.png"> 3. Go to Kibana > Stack Management > Upgrade assistant and there shouldn't be any critical errors.
1 parent 7a0b6ba commit ecd98ef

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎x-pack/plugins/infra/server/deprecations.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ export const getInfraDeprecationsFactory =
198198
const { name, fields } = configuration;
199199
for (const [key, defaultValue] of Object.entries(DEFAULT_VALUES)) {
200200
const configuredValue = Reflect.get(fields, key);
201-
if (configuredValue !== defaultValue) {
201+
if (configuredValue !== undefined && configuredValue !== defaultValue) {
202202
const affectedConfigNames = deprecatedFieldsToSourceConfigMap.get(key) ?? [];
203203
affectedConfigNames.push(name);
204204
deprecatedFieldsToSourceConfigMap.set(key, affectedConfigNames);

0 commit comments

Comments
 (0)