Improve Firefox browser process tracking (#25644)

Improve Firefox browser process tracking by using the -wait-for-browser
cmdline arg, and waiting longer for process startup.

Unfortunately `-wait-for-browser` is not enough to get rid of the
process delta polling, since the process handle returned by
`subprocess.Popen()` cannot be used to cascade the spawned Firefox
windows.

Waiting for 2 seconds for Firefox startup was not enough, so make the
wait time more conservative.

Add the detected processes to the list rather than replace, so that all
process handles are retained.

It may be possible to remove the use of
`launch_browser_harness_with_proc_snapshot_workaround()` for headless
Firefox runs, but more testing will be needed to verify that.

Author: juj

test/common.py

@@ -137,7 +137,7 @@ def configure(data_dir):
 
 class FirefoxConfig:
   data_dir_flag = '-profile '
-  default_flags = ('-new-instance',)
+  default_flags = ('-new-instance', '-wait-for-browser') if WINDOWS else ('-new-instance',)
   headless_flags = '-headless'
   executable_name = utils.exe_suffix('firefox')
 
@@ -2081,13 +2081,13 @@ def launch_browser_harness_with_proc_snapshot_workaround(cls, parallel_harness,
       # Give the browser time to spawn its subprocesses. Use an increasing
       # timeout as a crude way to account for system load.
       if parallel_harness or is_safari():
-        time.sleep(min(2 + count * 0.3, 10))
+        time.sleep(min(5 + count * 0.3, 10))
         procs_after = list_processes_by_name(config.executable_name)
 
         # Take a snapshot again to find which processes exist after launching
         # the browser. Then the newly launched browser processes are determined
         # by the delta before->after.
-        cls.browser_procs = list(set(procs_after).difference(set(procs_before)))
+        cls.browser_procs += list(set(procs_after).difference(set(procs_before)))
         if len(cls.browser_procs) == 0:
           exit_with_error('Could not detect the launched browser subprocesses. The test harness will not be able to close the browser after testing is done, so aborting the test run here.')