Merge pull request #1077 from entireio/prune-subsumed-strategy-tests

Prune subsumed tests in strategy package

Author: georg

cmd/entire/cli/strategy/common_test.go

@@ -23,88 +23,6 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestOpenRepository(t *testing.T) {
-	// Create a temporary directory for the test repository
-	tmpDir := t.TempDir()
-
-	// Initialize a git repository
-	repo, err := git.PlainInit(tmpDir, false)
-	if err != nil {
-		t.Fatalf("failed to init repo: %v", err)
-	}
-
-	// Create a test file and commit it
-	testFile := filepath.Join(tmpDir, "test.txt")
-	if err := os.WriteFile(testFile, []byte("test content"), 0o644); err != nil {
-		t.Fatalf("failed to write test file: %v", err)
-	}
-
-	worktree, err := repo.Worktree()
-	if err != nil {
-		t.Fatalf("failed to get worktree: %v", err)
-	}
-
-	if _, err := worktree.Add("test.txt"); err != nil {
-		t.Fatalf("failed to add file: %v", err)
-	}
-
-	if _, err := worktree.Commit("Initial commit", &git.CommitOptions{
-		Author: &object.Signature{
-			Name:  "Test User",
-			Email: "test@example.com",
-		},
-	}); err != nil {
-		t.Fatalf("failed to commit: %v", err)
-	}
-
-	// Change to the repository directory
-	t.Chdir(tmpDir)
-
-	// Test OpenRepository
-	openedRepo, err := OpenRepository(context.Background())
-	if err != nil {
-		t.Fatalf("OpenRepository(context.Background()) failed: %v", err)
-	}
-
-	if openedRepo == nil {
-		t.Fatal("OpenRepository(context.Background()) returned nil repository")
-	}
-
-	// Verify we can perform basic operations
-	head, err := openedRepo.Head()
-	if err != nil {
-		t.Fatalf("failed to get HEAD: %v", err)
-	}
-
-	if head == nil {
-		t.Fatal("HEAD is nil")
-	}
-
-	// Verify we can get the commit
-	commit, err := openedRepo.CommitObject(head.Hash())
-	if err != nil {
-		t.Fatalf("failed to get commit: %v", err)
-	}
-
-	if commit.Message != "Initial commit" {
-		t.Errorf("expected commit message 'Initial commit', got '%s'", commit.Message)
-	}
-}
-
-func TestOpenRepositoryError(t *testing.T) {
-	// Create a temporary directory without git repository
-	tmpDir := t.TempDir()
-
-	// Change to the non-repository directory
-	t.Chdir(tmpDir)
-
-	// Test OpenRepository should fail
-	_, err := OpenRepository(context.Background())
-	if err == nil {
-		t.Fatal("OpenRepository(context.Background()) should have failed in non-repository directory")
-	}
-}
-
 func TestWorktreeRoot_Cache(t *testing.T) {
 	// Uses t.Chdir + t.Setenv so cannot be parallel.
 	tmpDir := t.TempDir()

cmd/entire/cli/strategy/manual_commit_test.go

@@ -1002,62 +1002,6 @@ func TestAddCheckpointTrailer_ExistingTrailers(t *testing.T) {
 	}
 }
 
-func TestCheckpointInfo_JSONRoundTrip(t *testing.T) {
-	original := CheckpointInfo{
-		CheckpointID:     "a1b2c3d4e5f6",
-		SessionID:        "session-123",
-		CreatedAt:        time.Date(2025, 12, 2, 10, 0, 0, 0, time.UTC),
-		CheckpointsCount: 5,
-		FilesTouched:     []string{"file1.go", "file2.go"},
-	}
-
-	data, err := json.Marshal(original)
-	if err != nil {
-		t.Fatalf("json.Marshal() error = %v", err)
-	}
-
-	var loaded CheckpointInfo
-	if err := json.Unmarshal(data, &loaded); err != nil {
-		t.Fatalf("json.Unmarshal() error = %v", err)
-	}
-
-	if loaded.CheckpointID != original.CheckpointID {
-		t.Errorf("CheckpointID = %q, want %q", loaded.CheckpointID, original.CheckpointID)
-	}
-	if loaded.SessionID != original.SessionID {
-		t.Errorf("SessionID = %q, want %q", loaded.SessionID, original.SessionID)
-	}
-}
-
-func TestSessionState_JSONRoundTrip(t *testing.T) {
-	original := SessionState{
-		SessionID:  "session-123",
-		BaseCommit: "abc123def456",
-		StartedAt:  time.Date(2025, 12, 2, 10, 0, 0, 0, time.UTC),
-		StepCount:  10,
-	}
-
-	data, err := json.Marshal(original)
-	if err != nil {
-		t.Fatalf("json.Marshal() error = %v", err)
-	}
-
-	var loaded SessionState
-	if err := json.Unmarshal(data, &loaded); err != nil {
-		t.Fatalf("json.Unmarshal() error = %v", err)
-	}
-
-	if loaded.SessionID != original.SessionID {
-		t.Errorf("SessionID = %q, want %q", loaded.SessionID, original.SessionID)
-	}
-	if loaded.BaseCommit != original.BaseCommit {
-		t.Errorf("BaseCommit = %q, want %q", loaded.BaseCommit, original.BaseCommit)
-	}
-	if loaded.StepCount != original.StepCount {
-		t.Errorf("StepCount = %d, want %d", loaded.StepCount, original.StepCount)
-	}
-}
-
 func TestShadowStrategy_GetCheckpointLog_WithCheckpointID(t *testing.T) {
 	// This test verifies that GetCheckpointLog correctly uses the checkpoint ID
 	// to look up the log. Since getCheckpointLog requires a full git setup