Merge pull request #109 from fsprojects/Dev

Version 0.1.82

Author: faldor20

.github/workflows/publish.yml

@@ -45,7 +45,7 @@ jobs:
         with:
           node-version: '14'
 
-      - run: npm install
+      - run: yarn install
       - uses: actions/download-artifact@master
         with:
           name: CompiledProject

.vscode/launch.json

@@ -45,7 +45,7 @@
             "outFiles": [
                 "${workspaceFolder}/out/**/*.js"
             ],
-            "preLaunchTask": "npm: compile"
+            "preLaunchTask": "yarn: compile"
         },
         {
             "name": "Extension Tests",
@@ -59,7 +59,7 @@
             "outFiles": [
                 "${workspaceFolder}/out/test/**/*.js"
             ],
-            "preLaunchTask": "npm: watch"
+            "preLaunchTask": "yarn: watch"
         }
     ]
 }

.vscodeignore

@@ -1,22 +1,14 @@
-sample/**
-tests/**
-scripts/**
-spacemacs/**
-videos/**
-client/**
-**/obj/**
-**.vsix
-.vs
-.vscode
-.paket
-.ionide
-.devcontainer
-tests
 
-src/**
-packages
-#!src/FSharpLanguageServer/bin/Release/net6.0/osx.10.11-x64/publish/**
-#!src/FSharpLanguageServer/bin/Release/net6.0/win10-x64/publish/**
-#!src/FSharpLanguageServer/bin/Release/net6.0/linux-x64/publish/**
-!src/FSharpLanguageServer/bin/Release/net6.0/assembly/README.md
-!src/FSharpLanguageServer/bin/Release/net6.0//publish/**
+*
+**
+
+!.vsixmanifest
+!node_modules
+!out
+!Icon512.png
+!LICENSE.md
+!package.json
+!changeog.md
+!syntaxes/**
+!src/FSharpLanguageServer/bin/Release/net6.0/publish/**
+!src/FSharpLanguageServer/bin/Release/net6.0/assembly/README.md

README.md

@@ -88,7 +88,7 @@ The language server protocol (LSP) is very similar to the API defined by the F#
 Clone this repo to your system and build it:
 
 ```
-npm install
+yarn install
 dotnet build -c Release
 ```
 
@@ -120,15 +120,15 @@ Neovim with Deoplete completion:\
 Clone this repo to your system and build it:
 
 ```
-npm install
+yarn install
 
 # Pick the appropriate target based upon your OS 
-dotnet publish -c Release -r linux-x64 src/FSharpLanguageServer
-dotnet publish -c Release -r osx.10.11-x64 src/FSharpLanguageServer
-dotnet publish -c Release -r win10-x64 src/FSharpLanguageServer
+dotnet publish -c Release
+dotnet publish -c Release
+dotnet publish -c Release 
 ```
 
-Make sure that the FSharpLanguageServer (in `src/FSharpLanguageServer/bin/Release/netcoreapp3.0/PLATFORM/publish`) is in your PATH. Alternatively, you can set the path to the server executable manually within your .spacemacs user-config:
+Make sure that the FSharpLanguageServer (in `src/FSharpLanguageServer/bin/Release/net6.0/publish`) is in your PATH. Alternatively, you can set the path to the server executable manually within your .spacemacs user-config:
 
 ```
 (setq fsharp2-lsp-executable "/path/to/FSharpLanguageServer")
@@ -166,7 +166,7 @@ Any help is very much appreciated, issues, PR's, even just asking a question abo
 
 Run :
 
-- ``npm install`` to setup node deps (not needed unless you plan to build the vsix extension package)
+- ``yarn install`` to setup node deps (not needed unless you plan to build the vsix extension package)
 
 - ``dotnet tool restore`` to install paket
 
@@ -178,4 +178,19 @@ Essentially you just publish the language server with ``dotnet publish -c Releas
 
 If you want to try your newly created extension run ``code --install-extension build.vsix``
 
-You can also change the Fsharp.debug setting in vscode which will cause the installed extension to try to build fslsp when it launches. Very handy for testing many smaller changes without republishing the extension. 
+## Debugging
+Set the Fsharp.debug and fsharp.CustomDll path settings in vscode.
+fsharp.debug: Stops execution of the langserver until you attach the vscode debugger to the dotnet instance.
+fsharp.customDllPath: allows you to specify a dll to run instead of the packaged version of fslsp. 
+#### Live project:
+- Open two instances of vscode one in a testing project, one in the fsharp-language-server project
+- Make changes to the test project and then run ``dotnet publish`` in src\FSharpLanguageServer.
+- use the workspace settings in the test project to set fsharp.debug to true and fsharp.customDllPath to the path of the dll you just published
+- Reload the other instance of vscode and attach the debugger to monitor the changes.
+
+#### Tests:
+- Write a test for your problem
+- Change "test" to "ftest"
+- In the vscode debugger dropdown select ".net expecto tests"
+- Debug your test
+

changelog.md

@@ -1,6 +1,21 @@
+## 0.1.82 
+
+### Issues fixed
+- Hovering not working in various scenarios
+  - All but the last char of class members
+  - Keywords
+  - DU's where the name doesn't have a space between it and the pipe. eg: '|MyDu of string'
+- Renaming and goto definition not working when the cursor is next to the end of the word.
+- Renaming not working for DU's when the name touches the pipe
+- Not rebuilding the cache when fsproj has changed but assets.json has not 
+### Internal 
+- Switched to yarn
+
 ## 0.1.81
 - Added keywords to autocomplete
 - fixed a few bugs in the path normalization and caching
+- Added keywords to autocomplete
+- fixed a few bugs in the path normalization and caching
 ## 0.1.80
 - Using Ionide.projInfo for project cracking which should fix all unessicary rechecks due to building the project
 - Added a project cracking caching feature so that projects now load way faster after being opened ap least once.