Go 1.24 and golangci-lint v2.0 (nicksnyder#369)

Author: nicksnyder

.github/workflows/build.yml

@@ -13,7 +13,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v5
         with:
-          go-version: stable
+          go-version: '1.24'
       - name: Git checkout
         uses: actions/checkout@v4
       - name: Build

.github/workflows/golangci-lint.yml

@@ -16,8 +16,8 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: stable
+          go-version: '1.24'
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6
+        uses: golangci/golangci-lint-action@v7
         with:
-          version: v1.61
+          version: v2.0

.github/workflows/goreleaser.yml

@@ -18,7 +18,7 @@ jobs:
         name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: stable
+          go-version: '1.24'
       -
         name: Release
         uses: goreleaser/goreleaser-action@v6

.golangci.yaml

@@ -0,0 +1,6 @@
+version: "2"
+linters:
+  exclusions:
+    rules:
+      - path: rule_gen\.go
+        text: "QF1001:"

goi18n/common_test.go

@@ -1,6 +1,9 @@
 package main
 
-import "os"
+import (
+	"os"
+	"testing"
+)
 
 func mustTempDir(prefix string) string {
 	outdir, err := os.MkdirTemp("", prefix)
@@ -9,3 +12,9 @@ func mustTempDir(prefix string) string {
 	}
 	return outdir
 }
+
+func mustRemoveAll(t *testing.T, path string) {
+	if err := os.RemoveAll(path); err != nil {
+		t.Fatal(err)
+	}
+}

goi18n/extract_command_test.go

@@ -290,9 +290,9 @@ zero = "Zero translation"
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			indir := mustTempDir("TestExtractCommandIn")
-			defer os.RemoveAll(indir)
+			defer mustRemoveAll(t, indir)
 			outdir := mustTempDir("TestExtractCommandOut")
-			defer os.RemoveAll(outdir)
+			defer mustRemoveAll(t, outdir)
 
 			inpath := filepath.Join(indir, test.fileName)
 			if err := os.WriteFile(inpath, []byte(test.file), 0666); err != nil {
@@ -342,7 +342,7 @@ func TestExtractCommand(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	defer os.RemoveAll(outdir)
+	defer mustRemoveAll(t, outdir)
 	if code := testableMain([]string{"extract", "-outdir", outdir, "../example/"}); code != 0 {
 		t.Fatalf("expected exit code 0; got %d", code)
 	}

goi18n/merge_command.go

@@ -99,7 +99,7 @@ func (mc *mergeCommand) execute() error {
 	}
 	for _, path := range ops.deleteFiles {
 		// Ignore error since it isn't guaranteed to exist.
-		os.Remove(path)
+		_ = os.Remove(path)
 	}
 	return nil
 }

goi18n/merge_command_test.go

@@ -530,9 +530,9 @@ zero = "{{.Count}} unread emails"
 	for _, testCase := range testCases {
 		t.Run(testCase.name, func(t *testing.T) {
 			indir := mustTempDir("TestMergeCommandIn")
-			defer os.RemoveAll(indir)
+			defer mustRemoveAll(t, indir)
 			outdir := mustTempDir("TestMergeCommandOut")
-			defer os.RemoveAll(outdir)
+			defer mustRemoveAll(t, outdir)
 
 			infiles := make([]string, 0, len(testCase.inFiles))
 			for name, content := range testCase.inFiles {

i18n/message_template.go

@@ -61,7 +61,7 @@ func (mt *MessageTemplate) Execute(pluralForm plural.Form, data interface{}, fun
 	if t == nil {
 		return "", pluralFormNotFoundError{
 			pluralForm: pluralForm,
-			messageID:  mt.Message.ID,
+			messageID:  mt.ID,
 		}
 	}
 	parser := &template.TextParser{
@@ -75,7 +75,7 @@ func (mt *MessageTemplate) execute(pluralForm plural.Form, data interface{}, par
 	if t == nil {
 		return "", pluralFormNotFoundError{
 			pluralForm: pluralForm,
-			messageID:  mt.Message.ID,
+			messageID:  mt.ID,
 		}
 	}
 	return t.Execute(parser, data)

internal/plural/codegen/xml.go

@@ -26,7 +26,7 @@ type PluralGroup struct {
 // Name returns a unique name for this plural group.
 func (pg *PluralGroup) Name() string {
 	n := cases.Title(language.AmericanEnglish).String(pg.Locales)
-	return strings.Replace(n, " ", "", -1)
+	return strings.ReplaceAll(n, " ", "")
 }
 
 // SplitLocales returns all the locales in the PluralGroup as a slice.