-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Description
While @brycewray and I suspect it’s Goldmark-caused rather than Hugo-caused, the Goldmark developer seems to require Goldmark issues that are observed in Hugo to be proposed as Hugo issues before he will have anything to do with them. The relevant Goldmark bug is here: yuin/goldmark#180
This issue occurs with the Typographer extension in Hugo — including the most recent release, 0.92.0 — if goldmark is the selected parser. It doesn’t occur if Blackfriday is the selected parser and “smart” punctuation is activated. (Sadly, Blackfriday is deprecated and the last commit in its repo is from Oct 26, 2020.)
Consider the following text in a Markdown file:
John's dog is named Sam. The Smiths' dog is named Rover.Expected result: Each apostrophe should be a “smart”/curly apostrophe (’), given the default behavior of goldmark’s Typographer extension.
Actual result: Only the singular possessive (John's dog) has the “smart”/curly apostrophe, while the plural possessive (Smiths' dog) has the “dumb”/straight apostrophe (').
There are many other examples where the "smart" quotes fail to operate correctly, as shown on these two demo pages:
This issue has been mentioned in the Hugo forums multiple times:
- https://discourse.gohugo.io/t/smart-quotes-do-not-work-properly-in-hugo-with-goldmark/34266
- https://discourse.gohugo.io/t/curly-quotes-with-hugo/36441
While the bug may be upstream, the upstream maintainer does not speak English fluently and does not feel comfortable dealing with this issue, while many Hugo users speak English and may be able to fix it.
Please remove the "stale bot" equivalent that closed the previous Hugo issue so that we don't have to keep making meaningless updates to keep the still valid issue alive.
Thanks in advance for any help or consideration this issue may receive.
What version of Hugo are you using (hugo version)?
> hugo version hugo v0.92.0+extended linux/amd64 BuildDate=unknown
Does this issue reproduce with the latest release?
Yes.