Add roles and versions as new dimensions (in addition to language) #13679
+13,758
−5,866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bep
force-pushed
the
feat/roles-versions-5139
branch
6 times, most recently
from
864cfcd to
779649e
Compare
bep
force-pushed
the
feat/roles-versions-5139
branch
3 times, most recently
from
e914f3f to
6f88a60
Compare
bep
force-pushed
the
feat/roles-versions-5139
branch
3 times, most recently
from
01f9c33 to
cf40195
Compare
bep
force-pushed
the
feat/roles-versions-5139
branch
5 times, most recently
from
958d82b to
f131d38
Compare
bep
force-pushed
the
feat/roles-versions-5139
branch
10 times, most recently
from
9a2ad51 to
35d3765
Compare
bep
force-pushed
the
feat/roles-versions-5139
branch
2 times, most recently
from
3228817 to
99dda69
Compare
bep
force-pushed
the
feat/roles-versions-5139
branch
4 times, most recently
from
c9c7e81 to
c89ca86
Compare
bep
force-pushed
the
feat/roles-versions-5139
branch
11 times, most recently
from
e4fb147 to
920bdd7
Compare
Fixes gohugoio#519 Fixes gohugoio#13680 Fixes gohugoio#13663 Fixes gohugoio#13776 Fixes gohugoio#13855 Fixes gohugoio#13648 Fixes gohugoio#13996 Fixes gohugoio#14001 Fixes gohugoio#14031 Fixes gohugoio#13818
bep
force-pushed
the
feat/roles-versions-5139
branch
5 times, most recently
from
202ea2c to
5302ff7
Compare
bep
force-pushed
the
feat/roles-versions-5139
branch
from
5302ff7 to
2169f8a
Compare
This commit adjusts the code to match the comment 'make these foreach terminate with the same semantics' by modifying the toForEachIdentityProvider function. The function now correctly handles the different termination semantics between forEeachContentNode and ForEeachIdentity, ensuring that the iteration termination status is propagated correctly.
This commit refactors the createAllPages function to reduce code duplication. A local 'handle' function has been introduced to encapsulate the common logic for processing 'contentNodeSeq' and 'contentNodes', simplifying the switch statement and improving readability.
bep
force-pushed
the
feat/roles-versions-5139
branch
from
2169f8a to
7e88f1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #13776.