hugofs: Make node_modules a "special case" mount #14090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bep
force-pushed
the
feat/mountnodemodfromtheme-19196
branch
5 times, most recently
from
adc7164 to
0b159f0
Compare
For this and similar mounts in a theme: ```toml [[module.mounts]] source = 'node_modules/bootstrap' target = 'assets/vendor/bootstrap' ``` We first check the theme itself, then the project root. For backwards compatibility, we also make any `../../node_modules/...` `source` paths into `node_modules/...` paths when defined in themes/modules. Fixes gohugoio#14089
bep
force-pushed
the
feat/mountnodemodfromtheme-19196
branch
from
0b159f0 to
90af7b6
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds special handling for node_modules mounts in Hugo themes/modules. When a theme/module defines a mount with source starting with node_modules/, Hugo will now check the theme directory first, then fall back to the project root if not found.
- Implements a two-tier lookup strategy for
node_modulespaths in theme/module mounts - Adds backwards compatibility for the
../../node_modules/...pattern previously used to reference project-level node_modules - Normalizes
../../node_modules/...paths tonode_modules/...when defined in themes/modules
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| modules/collect.go | Adds nodeModulesRoot() helper and implements special case logic in normalizeMounts() to handle node_modules paths with fallback to project root |
| hugofs/hugofs_integration_test.go | Adds integration test covering the three scenarios: project-level node_modules, backwards-compatible ../../ prefix, and theme-level node_modules |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jmooring
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this and similar mounts in a theme:
We first check the theme itself, then the project root.
For backwards compatibility, we also make any
../../node_modules/...sourcepaths intonode_modules/...paths when defined in themes/modules.Fixes #14089