fix(bigquery): move MaxStaleness field to table level#10066
Merged
alvarowolfx merged 5 commits intogoogleapis:mainfrom Feb 3, 2025
Merged
fix(bigquery): move MaxStaleness field to table level#10066alvarowolfx merged 5 commits intogoogleapis:mainfrom
alvarowolfx merged 5 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
the
api: bigquery
shollyman
reviewed
Apr 30, 2024
Contributor
shollyman
left a comment
shollyman
left a comment
There was a problem hiding this comment.
general looks reasonable, but I'd like more details on what the table level field may actually control.
Member
|
@alvarowolfx is this still active or can this be closed? |
Contributor
Author
|
still blocked by internal b/338036701. Will reopen when it's done. |
shollyman
approved these changes
Feb 3, 2025
This was referenced Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sounds like updating MaxStaleness is not working, so an internal ticket was opened to check that part.
Fixes #10026