This repository was archived by the owner on Nov 12, 2025. It is now read-only.
fix: do not set BidiRpc to None when closing it - #698
Merged
Conversation
product-auto-label
Bot
added
size: xs
Linchin
enabled auto-merge (squash)
November 6, 2023 18:33
shollyman
approved these changes
Nov 6, 2023
shollyman
left a comment
shollyman
left a comment
Contributor
There was a problem hiding this comment.
Any tests that would be helpful to validate this, or are they already present?
Contributor
Author
|
I don't think there's a test covering this case. I can create another PR adding it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more context see comment #638 (comment).
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #638 🦕