Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: Add More Specific Type Annotations for Row Dictionaries - #1295

Merged
parthea merged 4 commits into
googleapis:mainfrom
waltaskew:better-type-annotations
Nov 16, 2022
Merged

fix: Add More Specific Type Annotations for Row Dictionaries#1295
parthea merged 4 commits into
googleapis:mainfrom
waltaskew:better-type-annotations

Conversation

@waltaskew

Copy link
Copy Markdown
Contributor
  • The keys must be strings as they represent column names. Update type
    annotations to reflect this.
@waltaskew
waltaskew requested review from a team and Neenu1995 July 20, 2022 21:47
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jul 20, 2022
@waltaskew
waltaskew force-pushed the better-type-annotations branch from 686ba40 to 70c643e Compare July 22, 2022 22:23
@waltaskew
waltaskew force-pushed the better-type-annotations branch from 70c643e to ec97e77 Compare August 1, 2022 21:22
The keys must be strings as they represent column names. Update type annotations
to reflect this.
@waltaskew
waltaskew force-pushed the better-type-annotations branch from ec97e77 to 0468067 Compare August 11, 2022 23:27
@parthea parthea added owlbot:run Add this label to trigger the Owlbot post processor. kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 12, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 12, 2022
@parthea
parthea requested a review from chalmerlowe September 6, 2022 19:42
@parthea

parthea commented Sep 6, 2022

Copy link
Copy Markdown
Contributor

@chalmerlowe Please could you take a look?

@aribray aribray changed the title Add More Specific Type Annotations for Row Dictionaries Nov 10, 2022
@aribray aribray added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 10, 2022
@aribray aribray added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2022
@aribray

aribray commented Nov 15, 2022

Copy link
Copy Markdown
Contributor

@parthea sorry for the delay. I reviewed/tested this and it was all good!

@aribray aribray added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2022
@parthea
parthea merged commit eb49873 into googleapis:main Nov 16, 2022
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
…apis#1295)

The keys must be strings as they represent column names. Update type annotations
to reflect this.

Co-authored-by: aribray <45905583+aribray@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.

5 participants