This repository was archived by the owner on Mar 6, 2026. It is now read-only.
fix: update error logging when converting to pyarrow column fails - #1836
Merged
Conversation
product-auto-label
Bot
added
size: s
This was referenced Mar 11, 2024
product-auto-label
Bot
added
size: m
chalmerlowe
marked this pull request as ready for review
March 18, 2024 14:16
Linchin
reviewed
Mar 18, 2024
Linchin
reviewed
Mar 18, 2024
Linchin
reviewed
Mar 18, 2024
Contributor
|
Thank you so much @chalmerlowe for fixing these issues! Mostly looks good, I just had some questions on the details. |
chalmerlowe
added
the
automerge
Linchin
approved these changes
Mar 18, 2024
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
Bot
removed
the
automerge
chalmerlowe
commented
Mar 19, 2024
This was referenced Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When conversion of a
pyarrowcolumn fails, the user is not provided adequate information about which column fails to convert. This PR provides additional context to identify the column (if the Series has a.nameparameter).Fixes #1621 🦕
Fixes #1822
This merges and replaces the follow PR(s):
#1824
#1622