Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

feat: add read_time support for get and query - #334

Merged
Mariatta merged 9 commits into
googleapis:mainfrom
yixiaoshen:ys-python-snapshot-read
Jul 15, 2022
Merged

feat: add read_time support for get and query#334
Mariatta merged 9 commits into
googleapis:mainfrom
yixiaoshen:ys-python-snapshot-read

Conversation

@yixiaoshen

@yixiaoshen yixiaoshen commented Jul 7, 2022

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #333 🦕
@yixiaoshen
yixiaoshen requested review from a team July 7, 2022 00:36
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: datastore Issues related to the googleapis/python-datastore API. labels Jul 7, 2022
@yixiaoshen

yixiaoshen commented Jul 7, 2022

Copy link
Copy Markdown
Contributor Author

R: @Mariatta
Mariatta
Mariatta suggested changes Jul 8, 2022
View reviewed changes

@Mariatta Mariatta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be great if we add in the doc that the read_time is in private preview.

Also seeing failed tests when running it locally.
Comment thread google/cloud/datastore/client.py
Comment thread google/cloud/datastore/client.py Outdated
Comment thread google/cloud/datastore/client.py Outdated
Comment thread google/cloud/datastore/client.py Outdated
Comment thread google/cloud/datastore/client.py Outdated
Comment thread google/cloud/datastore/query.py Outdated
Comment thread google/cloud/datastore/transaction.py Outdated
Comment thread google/cloud/datastore/transaction.py Outdated
Comment thread tests/unit/test_client.py
Comment thread tests/unit/test_helpers.py
yixiaoshen and others added 3 commits July 8, 2022 12:12
@yixiaoshen @Mariatta
Apply suggestions from code review
6f72f72 
Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com>
@yixiaoshen @Mariatta
Update google/cloud/datastore/client.py
8273d8c 
Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com>
@yixiaoshen
fix timezone issue in read_time unit tests
9a3c904
@Mariatta Mariatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 8, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 8, 2022
@yixiaoshen
yixiaoshen requested a review from Mariatta July 8, 2022 21:04
@Mariatta Mariatta added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2022
@Mariatta Mariatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2022
@Mariatta Mariatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2022
@Mariatta Mariatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 15, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 15, 2022
Mariatta
Mariatta approved these changes Jul 15, 2022
View reviewed changes

@Mariatta Mariatta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work!
@Mariatta
Mariatta merged commit 58b4b74 into googleapis:main Jul 15, 2022
@release-please release-please Bot mentioned this pull request Jul 15, 2022
Merged
This was referenced Aug 4, 2022
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/python-datastore API. size: l Pull request size is large.

3 participants

@yixiaoshen @Mariatta @yoshi-kokoro