Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

feat: Support "limit" in count query. - #384

Merged
Mariatta merged 9 commits into
mainfrom
feat-add-count-limit
Nov 30, 2022
Merged

feat: Support "limit" in count query.#384
Mariatta merged 9 commits into
mainfrom
feat-add-count-limit

Conversation

@Mariatta

@Mariatta Mariatta commented Nov 11, 2022

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@Mariatta
Mariatta requested review from a team November 11, 2022 00:59
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: datastore Issues related to the googleapis/python-datastore API. labels Nov 11, 2022
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 11, 2022
kolea2
kolea2 suggested changes Nov 14, 2022
View reviewed changes
Comment thread tests/system/test_aggregation_query.py Outdated
kolea2
kolea2 suggested changes Nov 15, 2022
View reviewed changes
Comment thread google/cloud/datastore/aggregation.py Outdated
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Nov 15, 2022
kolea2
kolea2 approved these changes Nov 15, 2022
View reviewed changes

@kolea2 kolea2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one doc fix needed!
Comment thread google/cloud/datastore/aggregation.py Outdated
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 15, 2022
@Mariatta
Mariatta merged commit a4b666a into main Nov 30, 2022
@Mariatta
Mariatta deleted the feat-add-count-limit branch November 30, 2022 16:34
@release-please release-please Bot mentioned this pull request Nov 30, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/python-datastore API. size: m Pull request size is medium.

2 participants

@Mariatta @kolea2